Don't reopen file handles in fhc:needs_sync/1, avoid infinite loop.

1 files changed, 6 insertions, 5 deletions

diff --git a/src/file_handle_cache.erl b/src/file_handle_cache.erl
index f3b4dbafa2..e8788c9798 100644
--- a/src/file_handle_cache.erl
+++ b/src/file_handle_cache.erl
@@ -374,11 +374,12 @@ sync(Ref) ->
       end).
 
 needs_sync(Ref) ->
-    with_handles(
-      [Ref],
-      fun ([#handle { is_dirty = false, write_buffer = [] }]) -> false;
-          ([_Handle])                                         -> true
-      end).
+    %% This needs *not* to use with_handles/2; see bug 25052
+    Handle = get({Ref, fhc_handle}),
+    case Handle of
+        #handle { is_dirty = false, write_buffer = [] } -> false;
+        _                                               -> true
+    end.
 
 position(Ref, NewOffset) ->
     with_flushed_handles(