summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorMichael Klishin <mklishin@pivotal.io>2019-02-13 12:52:18 +0300
committerMichael Klishin <mklishin@pivotal.io>2019-02-13 12:52:18 +0300
commit8ee96662e87386fd9fd1c7e3524bf9cc7f541617 (patch)
tree349c858e48b40a99d725030f42d607a603d0b894 /test
parent4ee79b92dde8fe9062213126e1c25d88b455c345 (diff)
downloadrabbitmq-server-git-8ee96662e87386fd9fd1c7e3524bf9cc7f541617.tar.gz
dynamic_ha suite: remove a racy assertion
Asserting that a process on a remote node is down at this very moment is inherently racy and opportunistic. rabbit_ct_broker_helpers:force_vhost_failure/2 will retry up to 10 times to make sure that the top vhost supervision tree process did go down. That is good enough. Per discussion with @kjnilsson.
Diffstat (limited to 'test')
-rw-r--r--test/dynamic_ha_SUITE.erl4
1 files changed, 2 insertions, 2 deletions
diff --git a/test/dynamic_ha_SUITE.erl b/test/dynamic_ha_SUITE.erl
index 6d03cff4dc..023f55648b 100644
--- a/test/dynamic_ha_SUITE.erl
+++ b/test/dynamic_ha_SUITE.erl
@@ -437,8 +437,8 @@ slave_recovers_after_vhost_down_and_up(Config) ->
%% Crash vhost on a node hosting a mirror
rabbit_ct_broker_helpers:force_vhost_failure(Config, B, <<"/">>),
- %% Vhost is down now
- false = rabbit_ct_broker_helpers:rpc(Config, B, rabbit_vhost_sup_sup, is_vhost_alive, [<<"/">>]),
+ %% rabbit_ct_broker_helpers:force_vhost_failure/2 will retry up to 10 times to
+ %% make sure that the top vhost supervision tree process did go down. MK.
timer:sleep(500),
%% Vhost is back up
case rabbit_ct_broker_helpers:rpc(Config, B, rabbit_vhost_sup_sup, start_vhost, [<<"/">>]) of