New policy validators test suite

Part of #2356.

2 files changed, 217 insertions, 1 deletions

diff --git a/test/unit_connection_tracking_SUITE.erl b/test/unit_connection_tracking_SUITE.erl
index 16c27ce3a3..6c089fd992 100644
--- a/test/unit_connection_tracking_SUITE.erl
+++ b/test/unit_connection_tracking_SUITE.erl
@@ -42,7 +42,7 @@ groups() ->
     ].
 
 %% -------------------------------------------------------------------
-%% Testsuite setup/teardown.
+%% Test suite setup/teardown.
 %% -------------------------------------------------------------------
 
 init_per_suite(Config) ->
diff --git a/test/unit_policy_validators_SUITE.erl b/test/unit_policy_validators_SUITE.erl
new file mode 100644
index 0000000000..d097140d57
--- /dev/null
+++ b/test/unit_policy_validators_SUITE.erl
@@ -0,0 +1,216 @@
+%% The contents of this file are subject to the Mozilla Public License
+%% Version 1.1 (the "License"); you may not use this file except in
+%% compliance with the License. You may obtain a copy of the License at
+%% https://www.mozilla.org/MPL/
+%%
+%% Software distributed under the License is distributed on an "AS IS"
+%% basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See the
+%% License for the specific language governing rights and limitations
+%% under the License.
+%%
+%% The Original Code is RabbitMQ.
+%%
+%% The Initial Developer of the Original Code is GoPivotal, Inc.
+%% Copyright (c) 2011-2020 VMware, Inc. or its affiliates.  All rights reserved.
+%%
+
+-module(unit_policy_validators_SUITE).
+
+-include_lib("common_test/include/ct.hrl").
+-include_lib("eunit/include/eunit.hrl").
+
+-compile(export_all).
+
+all() ->
+    [
+      {group, core_validators},
+      {group, classic_queue_mirroring_validators}
+    ].
+
+groups() ->
+    [
+      {core_validators, [parallel], [
+          alternate_exchange,
+          dead_letter_exchange,
+          dead_letter_routing_key,
+          message_ttl,
+          expires,
+          max_length,
+          max_length_bytes,
+          max_in_memory_length,
+          delivery_limit,
+          classic_queue_lazy_mode,
+          length_limit_overflow_mode
+        ]},
+        
+        {classic_queue_mirroring_validators, [parallel], [
+          classic_queue_ha_mode,
+          classic_queue_ha_params
+        ]}
+    ].
+
+%% -------------------------------------------------------------------
+%% Test suite setup/teardown.
+%% -------------------------------------------------------------------
+
+init_per_suite(Config) ->
+    rabbit_ct_helpers:log_environment(),
+    rabbit_ct_helpers:run_setup_steps(Config).
+
+end_per_suite(Config) ->
+    rabbit_ct_helpers:run_teardown_steps(Config).
+
+init_per_group(Group = classic_queue_mirroring_validators, Config) ->
+    Config1 = rabbit_ct_helpers:set_config(Config, [
+        {rmq_nodename_suffix, Group},
+        {rmq_nodes_count, 1}
+      ]),
+    rabbit_ct_helpers:run_steps(Config1,
+      rabbit_ct_broker_helpers:setup_steps());
+init_per_group(_, Config) ->
+    Config.
+
+end_per_group(classic_queue_mirroring_validators, Config) ->
+    rabbit_ct_helpers:run_steps(Config,
+      rabbit_ct_broker_helpers:teardown_steps());
+end_per_group(_, Config) ->
+    Config.
+
+init_per_testcase(Testcase, Config) ->
+    rabbit_ct_helpers:testcase_started(Config, Testcase).
+
+end_per_testcase(Testcase, Config) ->
+    rabbit_ct_helpers:testcase_finished(Config, Testcase).
+
+%% -------------------------------------------------------------------
+%% Core Validators
+%% -------------------------------------------------------------------
+
+alternate_exchange(_Config) ->
+    requires_binary_value(<<"alternate-exchange">>).
+
+dead_letter_exchange(_Config) ->
+    requires_binary_value(<<"dead-letter-exchange">>).
+
+dead_letter_routing_key(_Config) ->
+    requires_binary_value(<<"dead-letter-routing-key">>).
+
+message_ttl(_Config) ->
+    requires_non_negative_integer_value(<<"message-ttl">>).
+
+expires(_Config) ->
+    requires_positive_integer_value(<<"expires">>).
+
+max_length(_Config) ->
+    requires_non_negative_integer_value(<<"max-length">>).
+
+max_length_bytes(_Config) ->
+    requires_non_negative_integer_value(<<"max-length-bytes">>).
+
+max_in_memory_length(_Config) ->
+    requires_non_negative_integer_value(<<"max-in-memory-bytes">>).
+
+delivery_limit(_Config) ->
+    requires_non_negative_integer_value(<<"delivery-limit">>).
+
+classic_queue_lazy_mode(_Config) ->
+    test_valid_and_invalid_values(<<"queue-mode">>,
+        %% valid values
+        [<<"default">>, <<"lazy">>],
+        %% invalid values
+        [<<"unknown">>, <<"queue">>, <<"mode">>]).
+
+length_limit_overflow_mode(_Config) ->
+    test_valid_and_invalid_values(<<"overflow">>,
+        %% valid values
+        [<<"drop-head">>, <<"reject-publish">>, <<"reject-publish-dlx">>],
+        %% invalid values
+        [<<"unknown">>, <<"publish">>, <<"overflow">>, <<"mode">>]).
+
+
+%% -------------------------------------------------------------------
+%% CMQ Validators
+%% -------------------------------------------------------------------
+
+classic_queue_ha_mode(Config) ->
+    rabbit_ct_broker_helpers:rpc(Config, 0,
+        ?MODULE, classic_queue_ha_mode1, [Config]).
+
+classic_queue_ha_mode1(_Config) ->
+    ?assertEqual(ok, rabbit_mirror_queue_misc:validate_policy([
+        {<<"ha-mode">>, <<"exactly">>},
+        {<<"ha-params">>, 2}
+    ])),
+
+    ?assertEqual(ok, rabbit_mirror_queue_misc:validate_policy([
+        {<<"ha-mode">>, <<"nodes">>},
+        {<<"ha-params">>, [<<"rabbit@host1">>, <<"rabbit@host2">>]}
+    ])),
+
+    ?assertEqual(ok, rabbit_mirror_queue_misc:validate_policy([
+        {<<"ha-mode">>, <<"all">>}
+    ])),
+
+    ?assertMatch({error, _, _}, rabbit_mirror_queue_misc:validate_policy([
+        {<<"ha-mode">>, <<"lolwut">>},
+        {<<"ha-params">>, 2}
+    ])).
+
+classic_queue_ha_params(Config) ->
+    rabbit_ct_broker_helpers:rpc(Config, 0,
+        ?MODULE, classic_queue_ha_mode1, [Config]).
+
+classic_queue_ha_params1(_Config) ->
+    ?assertMatch({error, _, _}, rabbit_mirror_queue_misc:validate_policy([
+        {<<"ha-mode">>, <<"exactly">>},
+        {<<"ha-params">>, <<"2">>}
+    ])),
+
+    ?assertEqual(ok, rabbit_mirror_queue_misc:validate_policy([
+        {<<"ha-mode">>, <<"nodes">>},
+        {<<"ha-params">>, <<"lolwut">>}
+    ])),
+
+    ?assertEqual(ok, rabbit_mirror_queue_misc:validate_policy([
+        {<<"ha-mode">>, <<"all">>},
+        {<<"ha-params">>, <<"lolwut">>}
+    ])),
+
+    ?assertMatch({error, _, _}, rabbit_mirror_queue_misc:validate_policy([
+        {<<"ha-mode">>, <<"lolwut">>},
+        {<<"ha-params">>, 2}
+    ])).
+
+%%
+%% Implementation
+%%
+
+test_valid_and_invalid_values(Mod, Key, ValidValues, InvalidValues) ->
+    [begin
+         ?assertEqual(ok, Mod:validate_policy([
+            {Key, Val}
+         ]))
+     end || Val <- ValidValues],
+    [begin
+         ?assertMatch({error, _, _}, Mod:validate_policy([
+            {Key, Val}
+         ]))
+     end || Val <- InvalidValues].
+
+test_valid_and_invalid_values(Key, ValidValues, InvalidValues) ->
+    test_valid_and_invalid_values(rabbit_policies, Key, ValidValues, InvalidValues).
+
+requires_binary_value(Key) ->
+    test_valid_and_invalid_values(Key,
+        [<<"a.binary">>, <<"b.binary">>],
+        [1, rabbit]).
+
+requires_positive_integer_value(Key) ->
+    test_valid_and_invalid_values(Key,
+        [1, 1000],
+        [0, -1, <<"a.binary">>]).
+
+requires_non_negative_integer_value(Key) ->
+    test_valid_and_invalid_values(Key,
+        [0, 1, 1000],
+        [-1000, -1, <<"a.binary">>]).