summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Make rabbit_vhost:add/2 idempotentMichael Klishin2018-09-272-4/+19
| | | | | | Part of rabbitmq/rabbitmq-cli#260 [#160792770]
* Merge pull request #1701 from rabbitmq/get-empty-statsMichael Klishin2018-09-251-0/+1
|\ | | | | Add basic.get_empty stats as a new counter
| * Add get empty stats as a new counterDiana Corbacho2018-09-171-0/+1
| | | | | | | | | | Basic.get requests that return ok_empty used to be unaccounted for [#160280626]
* | Update rabbitmq-components.mkJean-Sébastien Pédron2018-09-191-2/+2
| |
* | tcp_listener_sup: Switch to ranch:child_spec/5Jean-Sébastien Pédron2018-09-191-5/+11
|/ | | | ranch:child_spec/6 is deprecated.
* Merge pull request #1700 from rabbitmq/rabbitmq-server-1699Michael Klishin2018-09-172-31/+102
|\ | | | | Make pg_local:member_died/2 more resilient
| * ClarifyMichael Klishin2018-09-171-1/+1
| |
| * Combine two clauses hereMichael Klishin2018-09-171-3/+1
| |
| * Make pg_local:member_died/2 more resilientMichael Klishin2018-09-152-31/+104
|/ | | | | | See #1699 for background. [#160530707]
* Update rabbitmq-components.mkJean-Sébastien Pédron2018-09-111-3/+3
|
* Merge pull request #1695 from rabbitmq/lrb-error-text-formattingMichael Klishin2018-09-085-47/+97
|\ | | | | Format errors and warnings with regard to config files in a manner si…
| * Format errors and warnings with regard to config files in a manner similar ↵Luke Bakken2018-09-065-47/+97
|/ | | | | | | | | | | | to lager Use exit code 64 when configuration is invalid Correctly deal with RABBITMQ_PID_FILE Fix bug in setting up RABBITMQ_PID_FILE as well as printing multi-line warnings and errors Calculate indent
* Merge pull request #1694 from rabbitmq/lrb-fix-badmatch-file-extensionMichael Klishin2018-09-051-5/+12
|\ | | | | Fix a potential badmatch error
| * Fix a potential badmatch errorLuke Bakken2018-09-051-5/+12
|/ | | | | | | | | | | | | | You can get `badmatch` if you run the broker with arguments like this: ``` make RABBITMQ_ALLOW_INPUT=true RABBITMQ_ADVANCED_CONFIG_FILE=/Users/lbakken/issues/pt/159000315-conf-format-check/test3/rabbitmq.conf RABBITMQ_CONFIG_FILE=/Users/lbakken/issues/pt/159000315-conf-format-check/test3/advanced.config run-broke ``` With this change, the following message is printed: ``` ERROR: RABBITMQ_ADVANCED_CONFIG_FILE: Expected extension .config, got extension .conf for file /Users/lbakken/issues/pt/159000315-conf-format-check/test3/rabbitmq.conf ```
* Move schema dir creation to the point it's going to be used.Daniil Fedotov2018-08-313-36/+36
| | | | | | On startup some environments do not expect schema dir if they use the old config. The script might fail with an error, while there is no reason to.
* Merge pull request #1691 from rabbitmq/remove-bindingsMichael Klishin2018-08-301-10/+4
|\ | | | | Idempotent binding removal
| * Remove a couple of sentences that may be slightly misleading nowMichael Klishin2018-08-301-4/+1
| | | | | | | | | | ...that we've concluded we cannot use dirty deletes in at least some areas. The sentence left is pretty to the point.
| * Idempotent binding removalDiana Corbacho2018-08-301-6/+3
| | | | | | | | | | | | | | | | | | | | Optimizations introduced in #1589 caused the removal of bindings to be non-idempotent, as the removal of routing information with dirty deletes did not allow for full transaction rollback. This commit reverts that change, losing some of the performance improvements in favour of data correctness. [#160100569]
* | Merge pull request #1689 from ↵Michael Klishin2018-08-301-5/+3
|\ \ | |/ |/| | | | | rabbitmq/forgiving-binding-removal-on-queue-deletion Don't error when a queue that's being deleted has no bindings left to remove on transaction retries
| * Don't error when a queue that's being deleted has no bindings to removeMichael Klishin2018-08-301-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | It can happen due to retries of (currently not guaranteed to be idempotent, which is a separate issue in the works) binding removal. Since both the queue and its bindings are undergoing removal, don't fail when there's nothing left to be removed for the current transaction [attempt]. This avoids obscure and non-actionable errors in the log ({error, not_found}). Note that the error is also not handled by the callers and ignoring them is the only reasonable course of action that I can think of. Per discussion with @dumbbell @dcorbacho @hairyhum.
* | Update git-commit-msgs linkLuke Bakken2018-08-281-1/+1
|/
* Merge pull request #1686 from rabbitmq/lrb-set_parameter-docsMichael Klishin2018-08-281-7/+7
|\ | | | | Change example to use parameter that exists
| * Change example to use parameter that existsLuke Bakken2018-08-271-7/+7
|/ | | | "federation local_username" does not exist anymore
* Merge pull request #1671 from rabbitmq/config_files_checkMichael Klishin2018-08-259-174/+399
|\ | | | | Config files check
| * Remove typoLuke Bakken2018-08-141-4/+0
| |
| * Add extension to default advanced config file name on windowsDaniil Fedotov2018-08-142-2/+2
| |
| * Batch file syntax errors. Config check error formatDaniil Fedotov2018-08-143-12/+16
| |
| * Use file:consult to check if .conf is of the old format. Add more errors to ↵Daniil Fedotov2018-08-141-3/+6
| | | | | | | | the .config check
| * Improve the error message when a config file is not in the correct formatDaniil Fedotov2018-08-141-7/+11
| |
| * Move file with no extension variable assignment before it's usedDaniil Fedotov2018-08-142-2/+4
| |
| * Do not add ./ to NOEX files if the file is in the current dirDaniil Fedotov2018-08-141-3/+7
| |
| * Do not show non-existent .conf file as a configuration file in logsDaniil Fedotov2018-08-141-1/+2
| |
| * Better warning and error messages in scripts.Daniil Fedotov2018-08-143-36/+65
| | | | | | | | | | If advanced config file has a wrong extension and is to be used as a -config argument - the script should fail with an error.
| * Fix function removing extension.Daniil Fedotov2018-08-141-3/+13
| | | | | | | | | | | | The ${FOO%.*} expression removes everything after the last dot, which returns wrong results for paths like /foo/bar.baz/bar. Make it use basename and dirname intead.
| * Simple validation for config file content and extension.Daniil Fedotov2018-08-146-14/+108
| |
| * Expect extensions in config filename argumentsDaniil Fedotov2018-08-141-12/+11
| |
| * Refactor config file discovery. Make advanced config load if no old format ↵Daniil Fedotov2018-08-146-151/+230
| | | | | | | | config is used
* | Merge pull request #1681 from rabbitmq/topology-recovery-in-statusMichael Klishin2018-08-231-5/+8
|\ \ | | | | | | Use process status to pass the auto_delete flag
| * | Use process status to pass the auto_delete flagDiana Corbacho2018-08-231-5/+8
|/ / | | | | | | | | Using a terminate reason makes the channel crash [#159483364]
* | Merge pull request #1675 from rabbitmq/topology-recoveryMichael Klishin2018-08-172-6/+31
|\ \ | | | | | | Increase performance of auto_delete queues deletion on channel down
| * \ Merge branch 'master' into topology-recoveryMichael Klishin2018-08-163-6/+20
| |\ \ | |/ / |/| |
* | | Merge pull request #1673 from rabbitmq/lrb-add-channel_max-detailLuke Bakken2018-08-151-3/+17
|\ \ \ | |_|/ |/| | Add detail for channel_max 0 value
| * | A typoMichael Klishin2018-08-151-1/+1
| | |
| * | A more precise commentMichael Klishin2018-08-151-1/+1
| | |
| * | Log errors as, well, errorsMichael Klishin2018-08-151-1/+1
| | |
| * | Improve formatting of logged connection.tune errors/exceptionsMichael Klishin2018-08-151-0/+7
| | |
| * | Add detail for channel_max 0 valueLuke Bakken2018-08-151-2/+9
|/ / | | | | | | | | | | It is not immediately obvious that a 0 value for channel_max means infinite or "no limit". This change will result in the following message being logged: "negotiated channel_max = 0 (no limit) is higher than the maximum allowed value (2047)"
* | Update rabbitmq.conf.exampleMichael Klishin2018-08-141-1/+1
| |
* | Merge pull request #1669 from noxdafox/priority-infoLuke Bakken2018-08-131-2/+2
|\ \ | | | | | | Handle generic data structures in priority queue info callback
| * | Handle generic data structures in priority queue info callbackMatteo Cafasso2018-08-121-2/+2
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The priority queue implementation makes assumptions over the data format returned by the underlying backing queue `info` callback. This causes priority queues to crash if used together with other modules implementing the `rabbit_backing_queue` behaviour and returning additional data with the `info` callback. As we cannot predict the format of the data the backing queue `info` callback could return, we just replace it with the undefined keyword. Signed-off-by: Matteo Cafasso <noxdafox@gmail.com>