summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Filter out all those events that look like:Simon MacMullen2013-02-271-0/+2
| | | | | | | | | =INFO REPORT==== 27-Feb-2013::14:17:46 === application: mnesia exited: stopped type: temporary since they are not very interesting and this bug makes them appear to a highly verbose extent.
* When we lose majority, stop the applications and wait for the cluster to ↵Simon MacMullen2013-02-271-4/+17
| | | | come back.
* cluster_cp_modeSimon MacMullen2013-02-183-0/+33
|
* explain a reader subletyMatthias Radestock2013-02-151-1/+3
|
* refactor: more symmetry in rabbit_reader:handle_dependent_exit/3Matthias Radestock2013-02-151-3/+3
| | | | | | It makes no difference whether we call handle_exception before or after control_throttle, so lets use an order that more clearly calls out the similarity to the controlled exit case.
* make reader's handling of channel.close_ok more obviously correctMatthias Radestock2013-02-151-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | by re-introducing a call to control_throttle. This was present in 3.0.x, and is needed there, but is actually not needed here, due to other changes made in the area. But the reason is quite subtle... For control_throttle to do something here, the channel_cleanup would have to be called for a channel for which we have run out of credit. Now, credit is only consumed when sending content-bearing methods to the channel with rabbit_channel:do_flow. There is a subsequent invocation of control_throttle in the code which will set the connection_state to 'blocking'. But this is immediately followed by a call to post_process_frame. The frame we are looking at must be the last frame of a content-bearing method, since otherwise the method would not be complete and we wouldn't have passed it to the channel. Hence that frame can only be a content_header or, more likely, a content_body. For both of these, post_process_frame invokes maybe_block, which will turn a 'blocking' into 'blocked'. And from that point onwards we will no longer read anything from the socket or process anything already in buf. So we certainly can't be processing a channel.close_ok. In other words, post_process_frame can only be invoked with a channel.close_ok frame when the connection_state is 'running', or blocking/blocked for a reason other than having run out of credit for a channel, i.e. an alarm. Therefore forgetting about the channel as part of the channel_cleanup call does not have an effect on credit_flow:blocked(). And hence an invocation of control_throttle will not alter the connection_state and is therefore unnecessary.
* make reader's handle_dependent_exit clearerMatthias Radestock2013-02-151-7/+7
| | | | | | - handle the no-op case (controlled exit of a channel we've forgotten about already) explicitly - better clause order and formatting.
* TypoSimon MacMullen2013-02-151-1/+1
|
* Merged bug25247Emile Joubert2013-02-155-37/+60
|\
| * tweakMatthias Radestock2013-02-151-9/+8
| |
| * explainMatthias Radestock2013-02-151-0/+10
| |
| * merge stable into defaultMatthias Radestock2013-02-1446-1479/+2337
| |\
| | * merge headsMatthias Radestock2013-02-141-13/+22
| | |\
| | | * Merge bug25451Simon MacMullen2013-02-140-0/+0
| | | |\
| | | * | drop_expired_msgs only when the queue head changesMatthias Radestock2013-02-131-11/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | And on recover. And when the timer goes off. That's all we need. new call sites: - in deliver_or_enqueue/3, when enqueuing a message (that we couldn't deliver to a consumer straight away) with an expiry to the head. the queue. NB: Previously we were always (re)setting a timer when enqueuing a message with an expiry, which is wasteful when the new message isn't at the head (i.e. the queue was non-empty) or when it needs expiring immediately. - requeue_and_run/2, since a message may get requeued to the head. This call site arises due to removal of the run_message_queue/1 call site (see below). unchanged call sites: - init_ttl/2 - this is the recovery case - fetch/2, after fetching - this is the basic "queue head changes" case - handle_info/drop_expired - this is the message expiry timer removed call sites: - run_message_queue/1 - this internally calls fetch/2 (see above) but also invoking drop_expired_msgs at the beginning. This now happens at the call sites, where it is necessary. Which actually only is in requeue_and_run, and not the others, none of which change the queue content prior to calling run_message_queue/1 - possibly_unblock/3 - unblocking of consumers - handle_call/basic_consumer - adding a consumer - handle_call/basic_get, prior to the call to fetch/2. - handle_call/stat
| | | * | don't invoke run_message_queue in handle_cast/run_backing_queueMatthias Radestock2013-02-131-2/+1
| | | |/ | | | | | | | | | | | | | | | | | | | | Since that would only be necessary of the BQ:invoke modified the consumers, which it can't, or added messages to the queue, which it shouldn't.
| | * | remove superfluous vqstate fieldMatthias Radestock2013-02-142-11/+3
| | |/
| | * Today's arbitrary startup banner change: centre the rabbit.Simon MacMullen2013-02-131-7/+7
| | |
| | * stable to defaultSimon MacMullen2013-02-131-5/+4
| | |\
| | * | optimiseMatthias Radestock2013-02-121-1/+7
| | | |
| * | | merge bug25419 into stableMatthias Radestock2013-02-140-0/+0
| |\ \ \ | | | |/ | | |/|
| * | | cosmeticMatthias Radestock2013-02-141-2/+2
| | | |
| * | | In case the containing process is trapping exits.Simon MacMullen2013-02-141-0/+1
| | | |
| * | | Don't stomp on the (possible) registered name of the thing that invokes ↵Simon MacMullen2013-02-141-4/+3
| | | | | | | | | | | | | | | | boot/0 or start/0, create a new process to hold the name instead.
| * | | If we try to stop while starting, wait until we have stopped starting before ↵Simon MacMullen2013-02-141-0/+8
| |/ / | | | | | | | | | stopping.
| * | Merge bug25448Simon MacMullen2013-02-130-0/+0
| |\ \
| * | | drop expired messages post basic_getMatthias Radestock2013-02-121-5/+4
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ...so messages with an expiry that are at the head of the queue after a basic.get do not get stuck there in the absence of other queue activity. Rather than simply adding a call to drop_expired_messages/1 after the call to fetch/1 in the basic_get code, we insert the call into fetch/1, which allows us to remove it from the other call site. Thus fetch/1 preserves the invariant we are after, namely that whenever a queue has a message at the head with an expiry, there is a timer set to drop said message. Note that the message count returned by basic.get does not reflect the dropping of expired messages after the fetched message. That's ok since we make no guarantee that messages are expired straight away. And note that on 'default' (rather than 'stable') the behaviour is actually different; due to various other changes there we will in fact return the reduced count.
* | | remove icky use of element/2Matthias Radestock2013-02-121-4/+5
| | |
* | | Tweak nodes policy to allow master removal and thus queue migrationSimon MacMullen2013-02-123-49/+73
| |/ |/|
* | Merge bug25044 (fa1429850857)Emile Joubert2013-02-122-19/+19
|\ \
| * \ Merge headsEmile Joubert2013-02-122-19/+19
| |\ \
| | * | startup logging tweaksMatthias Radestock2013-02-121-7/+5
| | | |
| | * | Tweak the message to make it slightly more obvious if it has hung.Simon MacMullen2013-02-111-2/+4
| | | |
| | * | a little bit of refactoring of channel.flow codeMatthias Radestock2013-02-111-12/+12
| | | |
| * | | Merged bug25044Emile Joubert2013-02-120-0/+0
| |\ \ \ | | |/ /
* | | | That doesn't need a name either (in fact even less so, since it never ends ↵Simon MacMullen2013-02-111-2/+1
|/ / / | | | | | | | | | up in the registry).
* | | Don't repeat yourself.Simon MacMullen2013-02-087-14/+7
|/ /
* | Merge stable into defaultEmile Joubert2013-02-083-2/+22
|\ \ | |/
| * Merged bug25443 into stableEmile Joubert2013-02-080-0/+0
| |\
| * | Only delete queues for which no HA policy exists.Simon MacMullen2013-02-061-2/+4
| | |
| * | Remove durable queues based on a node while forgetting that node.Simon MacMullen2013-02-062-1/+19
| |/
| * Merged bug25435 into stableEmile Joubert2013-02-051-1/+1
| |\
| | * We depend on xmerl via mochijson2.Simon MacMullen2013-02-041-1/+1
| |/
| * Added tag rabbitmq_v3_0_2 for changeset bf11b947abb9Simon MacMullen2013-01-310-0/+0
| |
* | Merge bug 25429Simon MacMullen2013-02-082-36/+21
|\ \
| * | Change to 'confirms' | 'other' | 'false'Simon MacMullen2013-02-082-3/+6
| | |
| * | merge bug25428 into bug25429Matthias Radestock2013-01-3137-1387/+2240
| |\ \
| * | | ask qi whether it needs sync'ing, and whyMatthias Radestock2013-01-302-32/+17
| | | |
| * | | merge bug25428 into bug25429Matthias Radestock2013-01-300-0/+0
| |\ \ \ | | | |/ | | |/|
* | | | Merged bug25433 into defaultEmile Joubert2013-02-051-1/+13
|\ \ \ \
View Lorry Controller Status