summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* Clarify that the delay is in ms in these log messagesMichael Klishin2020-06-271-2/+2
| | | | References #1627, #2276.
* Avoid using unfortunate terms in more placesMichael Klishin2020-06-268-113/+113
| | | | | | | | We have switched all doc guides to use "follower", "mirror" or "secondary" years ago but some comments and test suites were never updated, even though their changes would not be breaking. This transition is a medium-term WIP.
* Avoid using unfortunate terms in more placesMichael Klishin2020-06-265-12/+12
| | | | | | | | | We have switched all doc guides to use "mirror" or "secondary" years ago but these were never updated. Renaming functions and record/HTTP API fields (including CLI tools) would be major a breaking change, so they will be aliased or renamed with a lot more extensive review in the future.
* Avoid using unfortunate terms in more placesMichael Klishin2020-06-2611-82/+82
| | | | | | | | | We have switched all doc guides to use "mirror" or "secondary" years ago but these were never updated. Renaming functions and record/HTTP API fields (including CLI tools) would be major a breaking change, so they will be aliased or renamed with a lot more extensive review in the future.
* Avoid using unfortunate terms in code comments and log messagesMichael Klishin2020-06-2613-85/+85
| | | | | | | | | We have switched all doc guides to use "mirror" or "secondary replica" years ago but these were never updated. Renaming functions and record/HTTP API fields (including CLI tools) would be major a breaking change, so they will be aliased or renamed with a lot more extensive review in the future.
* Merge pull request #2396 from rabbitmq/rabbitmq-server-2384Michael Klishin2020-06-262-21/+32
|\ | | | | Import definitions in the post-launch phase
| * Avoid seeding default data if there are configured definitions to load on bootMichael Klishin2020-06-262-9/+27
| | | | | | | | | | | | | | | | | | This is a behavior we use to provide because definitions were imported before the empty DB boot step. Now when the definitions are imported in the post-launch phase, we'd always end up with default data seeded in addition to definitions being imported. References #2384
| * Export definitions on boot after all plugins have been enabledMichael Klishin2020-06-261-12/+5
|/ | | | | | | This way definitions that depend on a plugin, such as federation upstreams or exchanges of custom types, can be imported successfully. Closes #2384
* Merge pull request #2393 from rabbitmq/upgrade-cuttlefishJean-Sébastien Pédron2020-06-251-1/+1
|\ | | | | Makefile: Upgrade Cuttlefish from 2.2.0 to 2.3.0
| * Makefile: Upgrade Cuttlefish from 2.2.0 to 2.3.0Jean-Sébastien Pédron2020-06-251-1/+1
| | | | | | | | | | This fixes a crash of Cuttlefish when a line is made only of whitespaces.
* | Merge pull request #2392 from fenollp/nohipeMichael Klishin2020-06-257-253/+3
|\ \ | |/ |/| drop deprecated HiPE compilation
| * Keep the flag for backwards config compatibility.Pierre Fenoll2020-06-241-0/+9
| | | | | | | | Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
| * drop deprecated HiPE compilationPierre Fenoll2020-06-247-260/+1
| | | | | | | | Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
* | Fix a typo spotted by @VVDMichael Klishin2020-06-241-1/+1
|/ | | References #2389, #2387
* Merge pull request #2389 from ↵Michael Klishin2020-06-241-0/+28
|\ | | | | | | | | rabbitmq/restore-dist-port-configuration-for-windows-service scripts/rabbitmq-service.bat: Configure Erlang distribution port
| * scripts/rabbitmq-service.bat: Configure Erlang distribution portJean-Sébastien Pédron2020-06-191-0/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As said in the comment, this is normally done at runtime now (see rabbitmq/rabbitmq-server#2180). However, we must configure the distribution on the command line specifically for the Windows service. Until this patch, the distribution was enabled with the correct nodename, but the TCP port configuration was not set. This caused a regression because the selected TCP port was random instead of the expected default of 25672. This patch restores the previous behavior. Fixes rabbitmq/rabbitmq-server#2387.
* | Update erlang.mkJean-Sébastien Pédron2020-06-231-3/+71
|/
* Merge pull request #2378 from rabbitmq/load-conf-before-erlang-dist-setupJean-Sébastien Pédron2020-06-101-4/+4
|\ | | | | rabbit_prelaunch: Load configuration before Erlang dist. is started
| * rabbit_prelaunch: Load configuration before Erlang dist. is startedJean-Sébastien Pédron2020-06-101-4/+4
|/ | | | | | | | The reason is that kernel's `net_ticktime` can be configured in the Cuttlefish or Erlang configuration files. If we start the distribution first, then the configuration parameter is ignored. Fixes #2377.
* Merge pull request #2375 from rabbitmq/rabbit-fifo-int-test-stabilityPhilip Kuryloski2020-06-101-10/+14
|\ | | | | Attempt to increase rabbit_fifo_int_SUITE stability
| * Attempt to increase rabbit_fifo_int_SUITE stabilityPhilip Kuryloski2020-06-091-10/+14
| | | | | | | | | | Wait for messages to have been enqueued before proceeding with the body of the test case
* | Merge pull request #2374 from rabbitmq/metrics-suite-test-stabilityPhilip Kuryloski2020-06-101-3/+7
|\ \ | | | | | | Make connection_metric_idemp_test example rather than property based
| * | Replace connection_metric_idemp_test with specific casesPhilip Kuryloski2020-06-091-3/+7
| |/ | | | | | | | | | | | | | | rather than a property based test. The property test flakes occassionally, and without consistent input values. Idempotency should be properly demonstrated with 2 or more attempts at the action anyway.
* | Merge pull request #2376 from rabbitmq/simple-ha-test-stabilityPhilip Kuryloski2020-06-101-0/+16
|\ \ | | | | | | Stricter setup in the confirms_survive_* tests
| * | Stricter setup in the confirms_survive_* testsPhilip Kuryloski2020-06-091-0/+16
| |/ | | | | | | Wait until at least one message has been confirmed before triggering the survivable change
* | rabbit_prelaunch_conf: Style fixesJean-Sébastien Pédron2020-06-091-15/+20
| | | | | | | | Things like staying in the 80-column limit and spaces around '='.
* | More logging for boot time definition importMichael Klishin2020-06-091-0/+1
| | | | | | | | References #2368, #2373, rabbitmq/rabbitmq-management#818.
* | Don't try to load management.load_definitions in the coreMichael Klishin2020-06-091-11/+3
| | | | | | | | | | | | See #2368 comments for the background. References #2368, #2373.
* | Merge pull request #2373 from rabbitmq/revert-2368-lrb-fix-definition-importMichael Klishin2020-06-091-6/+1
|\ \ | |/ |/| Revert "Ensure rabbitmq_management is loaded"
| * Revert "Ensure rabbitmq_management is loaded"Michael Klishin2020-06-091-6/+1
|/
* Bump Recon to 2.5.1Michael Klishin2020-06-091-2/+2
| | | | | | for Erlang 23 compatibility of 'rabbitmq-diagnostics observer' References zhongwencool/observer_cli#68.
* Merge pull request #2371 from twjs76/support_paths_with_bracketsLuke Bakken2020-06-081-2/+2
|\ | | | | Support RABBITMQ_HOME paths containing brackets on windows
| * Support RABBITMQ_HOME paths containing brackets on windowsThomas Speckert2020-06-081-2/+2
|/ | | | | | | | | | If the environment variable RABBITMQ_HOME contained a path with either '(' or ')' (for example, a path under C:\Program Files (x86)\), then the script would unexpectedly exit with the error '\some\path was unexpected at this time'. This was caused by the parenthesis being interpreted as part of the batch 'if/else'. Adding quotes around the arguments to the SET command fixes the problem.
* Merge pull request #2368 from rabbitmq/lrb-fix-definition-importMichael Klishin2020-06-061-1/+6
|\ | | | | Ensure rabbitmq_management is loaded
| * Ensure rabbitmq_management is loadedLuke Bakken2020-06-051-1/+6
|/ | | | | | | | | | | This ensures that `rabbitmq_management` settings are available at this point in time. If the plugin is not available, this step is skipped because the application can not be loaded. To test: ``` RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS='-rabbitmq_management load_definitions "/tmp/defs.json"' ./sbin/rabbitmq-server ```
* Merge pull request #2366 from rabbitmq/rabbitmq-cli-426Michael Klishin2020-06-052-2/+6
|\ | | | | Deprecate 'ctl node_health_check'
| * Update rabbitmqctl(8) man pageMichael Klishin2020-06-051-2/+4
| |
| * Deprecate 'ctl node_health_check'Michael Klishin2020-06-051-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | * It requires a fully booted node, so not generally suitable for a Kubernetes readiness probe. * It can produce false positives * It is too intrusive and CPU-intensive to use at scale * Most operators do not understand what it really does and when they learn about it, consider it to be too opinionated and intrusive Time for the One True Health Check™ to retire from duty. Part of rabbitmq/rabbitmq-cli#426
* | rabbit: Use `rabbit_prelaunch` to get contextJean-Sébastien Pédron2020-06-041-2/+2
| | | | | | | | | | | | Before this patch, we were using `rabbit_env` directly which computed the environment again. In the end, we would compute the environment four times instead of just once.
* | rabbitmq-defaults.bat: Allow to override `$CONF_ENV_FILE`Jean-Sébastien Pédron2020-06-041-1/+5
|/ | | | It is already possible on Unix.
* Merge pull request #2364 from rabbitmq/rabbitmq-server-2363Michael Klishin2020-06-043-101/+278
|\ | | | | Improves logging for user and permission-related management functions
| * Log a message when 'ctl set_policy' succeedsMichael Klishin2020-06-041-6/+9
| | | | | | | | Part of rabbitmq/rabbitmq-server#2363
| * Improve logging of 'ctl authenticate_user' failuresMichael Klishin2020-06-041-0/+1
| | | | | | | | | | | | | | At debug level only since this code path is used by client connections and authentication failures for are already visibly logged as errors. Part of rabbitmq/rabbitmq-server#2363
| * Improve reporting of 'ctl change_password' failuresMichael Klishin2020-06-041-10/+23
| | | | | | | | Part of rabbitmq/rabbitmq-server#2363
| * Improve reporting of 'ctl set_user_tags' failuresMichael Klishin2020-06-041-8/+20
| | | | | | | | Part of rabbitmq/rabbitmq-server#2363
| * Improve reporting of 'ctl add_user' and 'ctl delete_user' failuresMichael Klishin2020-06-041-11/+37
| | | | | | | | Part of rabbitmq/rabbitmq-server#2363
| * Improve reporting of 'ctl clear_topic_permissions' failuresMichael Klishin2020-06-041-10/+56
| | | | | | | | Part of rabbitmq/rabbitmq-server#2363
| * CosmeticsMichael Klishin2020-06-041-10/+10
| |
| * CosmeticsMichael Klishin2020-06-041-2/+2
| |
| * Improve reporting of 'ctl clear_permissions' failuresMichael Klishin2020-06-041-27/+51
| | | | | | | | Part of rabbitmq/rabbitmq-server#2363
View Lorry Controller Status