summaryrefslogtreecommitdiff
path: root/scripts
Commit message (Collapse)AuthorAgeFilesLines
* Small changes to follow name and quote style.Luke Bakken2020-10-131-2/+2
|
* Capture and return rabbitmq-plugins exit code in rabbitmq-script-wrapperChunyi Lyu2020-10-131-0/+2
|
* Switch to MPL 2.0Michael Klishin2020-07-172-26/+10
|
* scripts/rabbitmq-script-wrapper: Don't mess with console redirectionJean-Sébastien Pédron2020-06-081-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | Console output is handled in the SysV init scripts consistently (no more differences between the Debian and RPM packages). See the previous commit. This fixes an issue for users who used to define $RABBITMQ_LOG_BASE in the environment and called this script directly (i.e. not using the SysV init scripts). Before commit 4b7048205d1afa80bb0d644acb90e13106b2b8c1 (which made it to RabbitMQ 3.8.4), `rabbitmq-script-wrapper` took $RABBITMQ_LOG_BASE from rabbitmq-env(8) or the environment. After the mentionned commit, $RABBITMQ_LOG_BASE was hard-coded to setup console redirection (in the case of Debian only) because rabbitmq-env(8) didn't have the variable anymore and thus was not sourced. For those users, it meant they couldn't override $RABBITMQ_LOG_BASE in the environment and call this script, even if they wanted to change the location of RabbitMQ actual log files. Now that console redirection is handled by the SysV init scripts, we can get rid of that code in `rabbitmq-script-wrapper`. Fixes rabbitmq/rabbitmq-server-release#131.
* Update copyright (year 2020)Jean-Sébastien Pédron2020-03-102-2/+2
|
* Allow operator to disable iptables client blockingMichele Baldessari2020-01-311-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently the resource agent hard-codes iptables calls to block off client access before the resource becomes master. This was done historically because many libraries were fairly buggy detecting a not-yet functional rabbitmq, so they were being helped by getting a tcp RST packet and they would go on trying their next configured server. It makes sense to be able to disable this behaviour because most libraries by now have gotten better at detecting timeouts when talking to rabbit and because when you run rabbitmq inside a bundle (pacemaker term for a container with an OCF resource inside) you normally do not have access to iptables. Tested by creating a three-node bundle cluster inside a container: Container bundle set: rabbitmq-bundle [cluster.common.tag/rhosp16-openstack-rabbitmq:pcmklatest] Replica[0] rabbitmq-bundle-podman-0 (ocf::heartbeat:podman): Started controller-0 rabbitmq-bundle-0 (ocf::pacemaker:remote): Started controller-0 rabbitmq (ocf::rabbitmq:rabbitmq-server-ha): Master rabbitmq-bundle-0 Replica[1] rabbitmq-bundle-podman-1 (ocf::heartbeat:podman): Started controller-1 rabbitmq-bundle-1 (ocf::pacemaker:remote): Started controller-1 rabbitmq (ocf::rabbitmq:rabbitmq-server-ha): Master rabbitmq-bundle-1 Replica[2] rabbitmq-bundle-podman-2 (ocf::heartbeat:podman): Started controller-2 rabbitmq-bundle-2 (ocf::pacemaker:remote): Started controller-2 rabbitmq (ocf::rabbitmq:rabbitmq-server-ha): Master rabbitmq-bundle-2 The ocf resource was created inside a bundle with: pcs resource create rabbitmq ocf:rabbitmq:rabbitmq-server-ha avoid_using_iptables="true" \ meta notify=true container-attribute-target=host master-max=3 ordered=true \ op start timeout=200s stop timeout=200s promote timeout=60s bundle rabbitmq-bundle Signed-off-by: Michele Baldessari <michele@acksyn.org>
* (c) bumpMichael Klishin2019-12-292-2/+2
|
* packaging: Don't load rabbitmq-env from init scriptsJean-Sébastien Pédron2019-12-161-10/+2
| | | | | | | | | | | | | This was used to define `$RABBITMQ_LOG_BASE`, but this variable is no longer define there. rabbitmq-env would also load `rabbitmq-env.conf` which could redefine `$RABBITMQ_LOG_BASE`, but this is a corner case and doesn't fit packaging well: packages already prepare a location for log files and will clean this location up on removal. Now, we set `$RABBITMQ_LOG_BASE` value in those scripts and get rid of rabbitmq-env load.
* Merge pull request #99 from spring-operator/polish-urls-apache-license-masterMichael Klishin2019-03-291-1/+1
|\ | | | | URL Cleanup
| * URL CleanupSpring Operator2019-03-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * [ ] http://www.apache.org/licenses/LICENSE-2.0 with 1 occurrences migrated to: https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200).
* | URL CleanupSpring Operator2019-03-202-2/+2
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # HTTP URLs that Could Not Be Fixed These URLs were unable to be fixed. Please review them to see if they can be manually resolved. * http://blog.listincomprehension.com/search/label/procket (200) with 1 occurrences could not be migrated: ([https](https://blog.listincomprehension.com/search/label/procket) result ClosedChannelException). * http://dozzie.jarowit.net/trac/wiki/TOML (200) with 1 occurrences could not be migrated: ([https](https://dozzie.jarowit.net/trac/wiki/TOML) result SSLHandshakeException). * http://dozzie.jarowit.net/trac/wiki/subproc (200) with 1 occurrences could not be migrated: ([https](https://dozzie.jarowit.net/trac/wiki/subproc) result SSLHandshakeException). * http://e2project.org (200) with 1 occurrences could not be migrated: ([https](https://e2project.org) result AnnotatedConnectException). * http://nitrogenproject.com/ (200) with 2 occurrences could not be migrated: ([https](https://nitrogenproject.com/) result ConnectTimeoutException). * http://proper.softlab.ntua.gr (200) with 1 occurrences could not be migrated: ([https](https://proper.softlab.ntua.gr) result SSLHandshakeException). * http://yaws.hyber.org (200) with 1 occurrences could not be migrated: ([https](https://yaws.hyber.org) result AnnotatedConnectException). * http://httpredir.debian.org/debian (302) with 1 occurrences could not be migrated: ([https](https://httpredir.debian.org/debian) result AnnotatedConnectException). * http://choven.ca (503) with 1 occurrences could not be migrated: ([https](https://choven.ca) result ConnectTimeoutException). # Fixed URLs ## Fixed But Review Recommended These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended. * http://fixprotocol.org/ (301) with 1 occurrences migrated to: https://fixtrading.org ([https](https://fixprotocol.org/) result SSLHandshakeException). * http://nsis.sourceforge.net/Setting_Environment_Variables (301) with 1 occurrences migrated to: https://nsis.sourceforge.io/Setting_Environment_Variables ([https](https://nsis.sourceforge.net/Setting_Environment_Variables) result AnnotatedConnectException). * http://erldb.org (UnknownHostException) with 1 occurrences migrated to: https://erldb.org ([https](https://erldb.org) result UnknownHostException). * http://www.rabbitmq.com/releases/rabbitmq-server/v (404) with 1 occurrences migrated to: https://www.rabbitmq.com/releases/rabbitmq-server/v ([https](https://www.rabbitmq.com/releases/rabbitmq-server/v) result 404). * http://www.rabbitmq.com/releases/rabbitmq-server/v% (404) with 1 occurrences migrated to: https://www.rabbitmq.com/releases/rabbitmq-server/v% ([https](https://www.rabbitmq.com/releases/rabbitmq-server/v%) result 404). ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * http://cloudi.org/ with 27 occurrences migrated to: https://cloudi.org/ ([https](https://cloudi.org/) result 200). * http://erlware.org/ with 1 occurrences migrated to: https://erlware.org/ ([https](https://erlware.org/) result 200). * http://inaka.github.io/cowboy-trails/ with 1 occurrences migrated to: https://inaka.github.io/cowboy-trails/ ([https](https://inaka.github.io/cowboy-trails/) result 200). * http://ninenines.eu with 6 occurrences migrated to: https://ninenines.eu ([https](https://ninenines.eu) result 200). * http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html with 1 occurrences migrated to: https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html ([https](https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) result 200). * http://www.actordb.com/ with 2 occurrences migrated to: https://www.actordb.com/ ([https](https://www.actordb.com/) result 200). * http://www.cs.kent.ac.uk/projects/wrangler/Home.html with 1 occurrences migrated to: https://www.cs.kent.ac.uk/projects/wrangler/Home.html ([https](https://www.cs.kent.ac.uk/projects/wrangler/Home.html) result 200). * http://www.debian.org/doc/debian-policy/ with 2 occurrences migrated to: https://www.debian.org/doc/debian-policy/ ([https](https://www.debian.org/doc/debian-policy/) result 200). * http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ with 1 occurrences migrated to: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ ([https](https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/) result 200). * http://www.rabbitmq.com/ with 2 occurrences migrated to: https://www.rabbitmq.com/ ([https](https://www.rabbitmq.com/) result 200). * http://www.rabbitmq.com/debian/ with 3 occurrences migrated to: https://www.rabbitmq.com/debian/ ([https](https://www.rabbitmq.com/debian/) result 200). * http://www.rabbitmq.com/monitoring.html with 2 occurrences migrated to: https://www.rabbitmq.com/monitoring.html ([https](https://www.rabbitmq.com/monitoring.html) result 200). * http://www.rebar3.org with 1 occurrences migrated to: https://www.rebar3.org ([https](https://www.rebar3.org) result 200). * http://contributor-covenant.org with 1 occurrences migrated to: https://contributor-covenant.org ([https](https://contributor-covenant.org) result 301). * http://contributor-covenant.org/version/1/3/0/ with 1 occurrences migrated to: https://contributor-covenant.org/version/1/3/0/ ([https](https://contributor-covenant.org/version/1/3/0/) result 301). * http://inaka.github.com/apns4erl with 1 occurrences migrated to: https://inaka.github.com/apns4erl ([https](https://inaka.github.com/apns4erl) result 301). * http://inaka.github.com/edis/ with 1 occurrences migrated to: https://inaka.github.com/edis/ ([https](https://inaka.github.com/edis/) result 301). * http://lasp-lang.org/ with 1 occurrences migrated to: https://lasp-lang.org/ ([https](https://lasp-lang.org/) result 301). * http://saleyn.github.com/erlexec with 1 occurrences migrated to: https://saleyn.github.com/erlexec ([https](https://saleyn.github.com/erlexec) result 301). * http://www.debian-administration.org/articles/286 with 1 occurrences migrated to: https://www.debian-administration.org/articles/286 ([https](https://www.debian-administration.org/articles/286) result 301). * http://www.erlang.org/download.html with 1 occurrences migrated to: https://www.erlang.org/download.html ([https](https://www.erlang.org/download.html) result 301). * http://www.mozilla.org/MPL/ with 5 occurrences migrated to: https://www.mozilla.org/MPL/ ([https](https://www.mozilla.org/MPL/) result 301). * http://zhongwencool.github.io/observer_cli with 1 occurrences migrated to: https://zhongwencool.github.io/observer_cli ([https](https://zhongwencool.github.io/observer_cli) result 301).
* Use ocf_attribute_target instead of crm_nodeMichele Baldessari2018-11-191-3/+3
| | | | | | | | | | | | | | | | | | | | | Instead of calling crm_node directly it is preferrable to use the ocf_attribute_target function. This function will return crm_node -n as usual, except when run inside a bundle (aka container in pcmk language). Inside a bundle it will return the bundle name or, if the meta attribute meta_container_attribute_target is set to 'host', it will return the physical node name where the bundle is running. Typically when running a rabbitmq cluster inside containers it is desired to set 'meta_container_attribute_target=host' on the rabbit cluster resource so that the RA is aware on which host it is running. Tested both on baremetal (without containers): Master/Slave Set: rabbitmq-master [rabbitmq] Masters: [ controller-0 controller-1 controller-2 ] And with bundles as well. Co-Authored-By: Damien Ciabrini <dciabrin@redhat.com>
* Use template in rabbitmq-script-wrapper for RabbitMQ user and groupLuke Bakken2018-09-131-1/+1
|
* Ensure ~rabbitmq/.erlang.cookie is readable after running a command as rootLuke Bakken2018-09-121-1/+17
| | | | Fixes #85
* Use sysexists exit codes in OCF agent scriptJacek Tomasiak2018-06-111-1/+1
| | | | | | | Exit codes from sysexits.h were introduced in rabbitmq CLI with https://github.com/rabbitmq/rabbitmq-server/pull/412. The OCF agent for non-clustered setup was not updated and some exit codes were incorrectly reported as unexpected.
* OCF RA: Do not consider local failures as remote node problemsVincent Untz2017-12-201-4/+4
| | | | | | | | | | | | | | | | | In is_clustered_with(), commands that we run to check if the node is clustered with us, or partitioned with us may fail. When they fail, it actually doesn't tell us anything about the remote node. Until now, we were considering such failures as hints that the remote node is not in a sane state with us. But doing so has pretty negative impact, as it can cause rabbitmq to get restarted on the remote node, causing quite some disruption. So instead of doing this, ignore the error (it's still logged). There was a comment in the code wondering what is the best behavior; based on experience, I think preferring stability is the slightly more acceptable poison between the two options.
* OCF RA: Fix syntax errorVincent Untz2017-12-141-1/+1
| | | | (cherry picked from commit a9b4a4ff97a96e798de51933fc44f61aa6bc88a3)
* Merge pull request #64 from vuntz/ocf-fix-notify-startMichael Klishin2017-12-121-4/+3
|\ | | | | OCF RA: Fix various issues with start notification handler
| * OCF RA: Fix logging in start notification handlerVincent Untz2017-12-081-1/+1
| | | | | | | | | | | | The "post-start end" log message was written too early (some things were still done afterwards), and not in all cases (it was inside a if statement).
| * OCF RA: Do not start rabbitmq if notification of start is not about usVincent Untz2017-12-081-2/+1
| | | | | | | | | | | | | | | | | | | | Right now, every time we get a start notification, all nodes will ensure the rabbitmq app is started. This makes little sense, as nodes that are already active don't need to do that. On top of that, this had the sideeffect of updating the start time for each of these nodes, which could result in the master moving to another node.
| * OCF RA: Fix test for no node in start notification handlerVincent Untz2017-12-081-1/+1
| | | | | | | | | | | | If there's nothing starting and nothing active, then we do a -z " ", which doesn't have the same result as -z "". Instead, just test for emptiness for each set of nodes.
* | OCF RA: Avoid promoting nodes with same start time as masterVincent Untz2017-12-081-0/+5
|/ | | | | | | It may happen that two nodes have the same start time, and one of these is the master. When this happens, the node actually gets the same score as the master and can get promoted. There's no reason to avoid being stable here, so let's keep the same master in that scenario.
* Detect util-linux version of runuserLuke Bakken2017-09-201-1/+12
| | | | | | | Alternative is to always use runuser invocation in else clause. Fixes #44. [#150221349]
* Use runuser in non-su-compatible modeLuke Bakken2017-09-201-9/+3
| | | | | | | | | Remove argument quoting which is not necessary as long as command is passed to `/sbin/runuser` and `/bin/su` as arguments instead of a string. Fixes #44. [#150221349]
* Define shell explicitly for runuser commandJean-Sébastien Pedron2017-08-311-1/+1
| | | | | | | | | | | | Because the rabbitmq user shell defaults to /bin/false, we must explicitly define a shell when using the runuser command Issue: rabbitmq/rabbitmq-server-release#32 PR: rabbitmq/rabbitmq-server-release#40 [#150221349] Signed-off-by: Gerhard Lazu <gerhard@rabbitmq.com>
* Change runuser arguments to support more platformsDaniil Fedotov2017-08-221-1/+1
|
* Error message change from review.Luke Bakken2017-08-171-1/+1
|
* Fixes for SELinux supportLuke Bakken2017-08-161-1/+10
| | | | | Use /sbin/runuser to execute script as the `rabbitmq` user as this command does not cause issues with SELinux. See #32 for details.
* Merge branch 'stable'Jean-Sébastien Pédron2017-08-011-7/+12
|\
| * scripts/rabbitmq-script-wrapper: Run rabbitmq-plugin as root onlyJean-Sébastien Pédron2017-08-011-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous patch was meant to make it clear that an unprivileged user (other than `rabbitmq`) shouldn't run rabbitmq-plugins. Unfortunately, it broke the script when called by root, because the real script was executed as `rabbitmq`. This user doesn't have write permissions to `/etc/rabbitmq` by default. Now, rabbitmq-plugins' wrapper must be executed as root and so is the real script. This should fix the problem described above. [#149840153]
* | Ensure we are in a readable dir when running RabbitMQ scriptsJean-Sébastien Pedron2017-07-281-0/+6
| | | | | | | | | | | | | | | | | | If the current working directory is not readable, Erlang will crash. This ensures that we run RabbitMQ scripts from a readable directory. [#149425921] Signed-off-by: Gerhard Lazu <gerhard@rabbitmq.com>
* | Refactor rabbitmq-script-wrapperJean-Sébastien Pedron2017-07-281-21/+59
| | | | | | | | | | | | | | | | | | | | The logic is a bit crazy, and the whole purpose of this script is questionable, but until we get rid of it, we've refactor it to make it more obvious just how crazy it actually is. [#149425921] Signed-off-by: Gerhard Lazu <gerhard@rabbitmq.com>
* | Merge branch 'stable'Gerhard Lazu2017-07-281-1/+1
|\ \ | |/
| * Require root or rabbitmq user for rabbitmq-plugins.Daniil Fedotov2017-07-241-1/+1
| | | | | | | | | | | | | | | | | | | | For some reason, the rabbitmq-plugins command could be run from arbitrary user, which would result in errors unable to access a cookie file or plugins configuration files. Changed to work the same way as rabbitmqctl - require root or rabbitmq user. [Fixes #149425921]
| * Fix HA OCF scriptMate Lakat2017-05-092-1/+28
| | | | | | | | | | | | Some parts of #21 have not been added to the stable branch. This change fixes the issue by adding missing changes to rabbitmq-server-ha.ocf and also fixing rabbitmq-server.ocf
| * Enlist OCF_RESKEY_limit_nofile_default on commentMate Lakat2017-05-091-0/+1
| | | | | | | | Minor change to be consistent with the rest of the file.
| * Re-do #21Mate Lakat2017-05-091-0/+14
| | | | | | | | | | | | | | | | For some reason some changes were lost from #21, adding back those. The original PR message: This enables to change the limit of open files, as the default on distributions is usually too low for rabbitmq. Default is 65535.
| * Log rabbitmqctl's output on failureMate Lakat2017-05-031-1/+1
| | | | | | | | | | | | | | It would be helpful to see rabbit's output when it exits with non-zero status code. The log level is left at info, as it might be business as usual that a node is not running rabbit. The -q switch prevents the output from being logged if the return value is zero.
* | Fix HA OCF scriptMate Lakat2017-05-101-1/+1
| | | | | | | | | | | | Some parts of #21 have not been added to the stable branch. This change fixes the issue by adding missing changes to rabbitmq-server-ha.ocf and also fixing rabbitmq-server.ocf
* | Enlist OCF_RESKEY_limit_nofile_default on commentMate Lakat2017-05-101-0/+1
| | | | | | | | Minor change to be consistent with the rest of the file.
* | Re-do #21Mate Lakat2017-05-091-0/+14
| | | | | | | | | | | | | | | | For some reason some changes were lost from #21, adding back those. The original PR message: This enables to change the limit of open files, as the default on distributions is usually too low for rabbitmq. Default is 65535.
* | Log rabbitmqctl's output on failureMate Lakat2017-05-031-1/+1
| | | | | | | | | | | | | | It would be helpful to see rabbit's output when it exits with non-zero status code. The log level is left at info, as it might be business as usual that a node is not running rabbit. The -q switch prevents the output from being logged if the return value is zero.
* | Merge branch 'stable'Michael Klishin2017-04-051-15/+0
|\ \ | |/ | | | | | | Conflicts: scripts/rabbitmq-server.ocf
| * Manually backport #20, #21, #24, #25 by @vuntz and @aplanas to stableMichael Klishin2017-04-052-21/+16
| |
| * OCF RA: Add new limit_nofile parameter to rabbitmq-server OCF RAAlberto Planas2017-04-051-0/+19
| | | | | | | | | | This enables to change the limit of open files, as the default on distributions is usually too low for rabbitmq. Default is 65535.
| * OCF RA: Don't hardcode primitive name in rabbitmq-server-ha.ocfVincent Untz2017-03-311-1/+2
| | | | | | | | | | | | | | | | We can compute the name of the primitive automatically from environment variables, instead of hard-coding p_rabbitmq-server; this makes the resource agent more flexible. Closes https://github.com/rabbitmq/rabbitmq-server-release/issues/23
| * OCF RA: accept 1 as valid exit code from "rabbitmqctl status"Vincent Untz2017-03-311-1/+1
| | | | | | | | | | It may return 1 if the server is not completely running yet, and we don't want pacemaker to treat that as a complete unexpected error.
| * OCF RA: Use rabbitmqctl_action wrapper for stop actionVincent Untz2017-03-311-1/+1
| | | | | | | | | | We want to use the wrapper function to call rabbitmqctl for stop, so that we interpret correctly the exit code.
| * Add Travis tests for Pacemaker OCF RA clusterBogdan Dobrelya2016-11-251-30/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a matrix of two test cases: * Smoke test: just a check if rabbit cluster assembles. * Jepsen test: allowed to fail, it's main value is to verify cluster auto-healing after consequent network partitions and to provide numbers for duplicated/lost/recovered/unexpected messages as well. * Pin the cluster installer repo to the 1.2.0. Backport from master branch Make the gate always passing if there is no changes found to the RabbitMQ OCF RA script in the patch under test. Signed-off-by: Bogdan Dobrelya <bdobrelia@mirantis.com>
* | Merge pull request #21 from vuntz/ocf-limit_nofileMichael Klishin2017-04-052-0/+42
|\ \ | | | | | | OCF RA: Add new limit_nofile parameter to both OCF resource agents