delta/ruby-gems/rack.git, branch response-documentation

Revert moving attributes below `#initialize`.

2020-01-23T23:08:16+00:00

Fix documentation type syntax.

2020-01-23T23:08:16+00:00

Do more exact matching of domain and path when deleting cookies

2020-01-23T23:00:26+00:00

Also, correctly handle deleting with both a domain and path
provided.

Fixes #1234

Document `Rack::Response#initialize` and `#finish`.

2020-01-23T22:42:03+00:00

Require request env not be frozen in SPEC

2020-01-23T21:06:15+00:00

A frozen request env would break Rack::Request.

Update SPEC and Lint to require ASCII-8BIT encoding for CGI values with non-ASCII characters

2020-01-23T21:03:20+00:00

Fixes warning when binary Regexp is used to match against a
CGI value (QUERY_STRING).

ASCII-8BIT encoding is already required for response bodies.
Requiring this encoding for all CGI values would break usage
with puma and potentially other rack servers. So it seems
safest to only require ASCII-8BIT encoding when the value
actually contains non-ASCII.  We could further limit it to
just QUERY_STRING, but I'm not sure we want to do that.

Testing with a few rack servers:

* Unicorn always uses ASCII-8BIT for all CGI values.
* Puma will use UTF-8 for some values, but uses ASCII-8BIT
  for CGI values contianing non-ASCII characters.
* Webrick doesn't support non-ASCII chracters, at least for
  PATH_INFO or QUERY_STRING.

If we don't do this, the only way to avoid the warning would be
to duplicate QUERY_STRING if it is not already binary.  Checking
encoding will slow down parsing even if it already uses
ASCII-8BIT encoding.

Fixes #1183

Don't add headers when gzipped file returned 304

2020-01-23T19:52:41+00:00

Fix test that expects UTF-8 default_external encoding

2020-01-23T19:51:10+00:00

This test broke if UTF-8 is not the default_external encoding.

Add back test for etag with no-cache

2020-01-23T18:25:19+00:00

The behavior changed in the previous commit, but I think it is
better to specify the new behavior versus leaving it unspecified.

Remove check for Cache-Control: no-cache when generating etag

2020-01-23T18:18:54+00:00