delta/systemd.git/src/network/networkd-setlink.c, branch main

network: Fix set bond device MAC address failed

2022-12-05T11:48:45+00:00

Issue:
When device is in bond mode and booting up, there is a probability of
set bond MAC address failed due to `Device or resource busy` error.

In systemd-networkd, set MAC address steps are:
1. Try to set MAC address to device.
2. If failed with `Device or resource busy`, then `Down` the device.
3. Try to set MAC address to device again.

Currently, Even down the bond device, the bond device is still return
`Device or resource busy` error. So the MAC address set failed.

The root cause is that this not enough to down the bond device. We need
to down all the slaves of the bond device.
About this descprition, we could use those commands to check:
```shell
We have two network devices: eth0, bond1, eth0 is slave of bond1.
They are all up.

1. Down bond1, and set MAC address to bond1.
~# ip link set bond1 down
~# ip link set bond1 address 00:11:22:33:44:55
ip: SIOCSIFHWADDR: Device or resource busy

2. Down eth0, and set MAC address to bond1.
~# ip link set eth0 down
~# ip link set bond1 address 00:11:22:33:44:55
Set okay.
```

Fix:
When setting the mac for the second time, if the device kind is bond,
then we need to down the slave devices of bond device.

Tested: Verified in a long time test( reboot cycles ).

Fixes: #25627

Signed-off-by: Jian Zhang

network: skip to reassign master ifindex if already set

2022-10-31T20:13:49+00:00

Otherwise, the slave interface may go down, especially when the master
is bond.

Fixes #25067.

network/bridge: fix UseBPDU= and AllowPortToBeRoot=

2022-08-13T21:56:05+00:00

Fixes bugs caused by 7f9915f0de67f3a10a4b22810d119da65af8c84a.

Fixes #24268.

network: also check SR-IOV PF port and other VF ports before configuring

2022-08-05T12:49:27+00:00

When a PF port becomes down (this can happens e.g. the PF port is joining
a bond interface), some drivers make its VF ports also become down, and
may cause failures in configuring VF ports.

Similary, when a VF port become down, some drivers make its PF port and
other VF ports down.

Let's configure SR-IOV ports (both PF and VFs) after all link-layer
settings of all ports being applied.

Fixes #23315.

network: unset master ifindex only when necessary

2022-08-05T12:49:27+00:00

network: do not try to bring up wifi interface if rfkill is active

2022-07-23T11:55:03+00:00

This fixes the following error:
---
systemd-networkd[465]: wlan0: Could not bring up interface: Operation not possible due to RF-kill
---

Fixes #23649.

network: do not silently stop to process configuration on activation failure

2022-07-22T23:11:36+00:00

Previously, if activation failed, link did not enter the failed state,
but still Link.activated flag not set. Hence, nothing processed even if
the interface is manually brought up later.

Partially fixes #23649.

network: re-design request queue

2022-03-11T05:20:31+00:00

This makes Request object takes hash, compare, free, and process functions.

With this change, the logic in networkd-queue.c can be mostly
independent of the type of the request or the object (e.g. Address) assigned
to the request, and it becomes simpler.

network: merge RequestType and SetLinkOperation

2022-03-11T05:20:31+00:00

These two enum indicate how we process the request. Hence, it is not
necessary to introduce two separated indicators.

network: refuse to configure link properties when in initialized state

2022-03-11T05:20:31+00:00

The condition should be satisfied only when users request to reconfigure
the link, and in that case, all request will be cancelled. Hence, it is
not necessary to process the request.