Make 1-element arrays for fields that may repeat.

For various opaque LSAs, not only is the value of the TLV a "may
repeat", the TLVs *themselves* may repeat.

Also, pass a pointer to the TLV to ospf_print_grace_lsa() and
ospf_print_te_lsa(), rather than a pointer to the type field, as they
dissect a sequence of TLVs.

Hopefully, that will address Coverity CID 1426916, 1426917, and 1426920.

1 files changed, 3 insertions, 3 deletions

diff --git a/ospf.h b/ospf.h
index 4dca0af3..ae7d2f94 100644
--- a/ospf.h
+++ b/ospf.h
@@ -230,21 +230,21 @@ struct lsa {
 	    nd_uint16_t type;
 	    nd_uint16_t length;
 	    nd_byte     data[1]; /* may repeat   */
-	} un_te_lsa_tlv;
+	} un_te_lsa_tlv[1]; /* may repeat */
 
         /* Opaque Grace LSA */
         struct {
 	    nd_uint16_t type;
 	    nd_uint16_t length;
 	    nd_byte     data[1]; /* may repeat   */
-	} un_grace_tlv;
+	} un_grace_tlv[1]; /* may repeat */
 
         /* Opaque Router information LSA */
         struct {
 	    nd_uint16_t type;
 	    nd_uint16_t length;
 	    nd_byte     data[1]; /* may repeat   */
-	} un_ri_tlv;
+	} un_ri_tlv[1]; /* may repeat */
 
         /* Unknown LSA */
         struct unknown {