diff options
| author | Guy Harris <guy@alum.mit.edu> | 2010-02-21 00:27:00 -0800 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2010-02-21 00:27:00 -0800 |
| commit | e8b523758959c1854689d71c7a4686c631e5501c (patch) | |
| tree | 67d50632c8f8f0410d2a8d227a78709a7aca1ca2 /print-pflog.c | |
| parent | b00042a8ae3656f01e022bf6df1eb761e6323d3d (diff) | |
| download | tcpdump-e8b523758959c1854689d71c7a4686c631e5501c.tar.gz | |
Don't directly fetch multi-byte integers from packets.
Use the EXTRACT_ macros to extract multi-byte integral values from
packets, rather than just dereferencing pointers into the packet; there
is no guarantee that the packet data will be aligned on the right
boundary, and there is no guarantee that, if they're not, a direct
access will work correctly.
Diffstat (limited to 'print-pflog.c')
| -rw-r--r-- | print-pflog.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/print-pflog.c b/print-pflog.c index 972cb4b1..d1a46156 100644 --- a/print-pflog.c +++ b/print-pflog.c @@ -94,8 +94,8 @@ pflog_print(const struct pfloghdr *hdr) { u_int32_t rulenr, subrulenr; - rulenr = ntohl(hdr->rulenr); - subrulenr = ntohl(hdr->subrulenr); + rulenr = EXTRACT_32BITS(&hdr->rulenr); + subrulenr = EXTRACT_32BITS(&hdr->subrulenr); if (subrulenr == (u_int32_t)-1) printf("rule %u/", rulenr); else |