summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorDenis Ovsienko <denis@ovsienko.info>2020-02-04 22:30:10 +0000
committerDenis Ovsienko <denis@ovsienko.info>2020-02-04 23:02:07 +0000
commit05169ee13227f91e656e715cfc831d416447e39f (patch)
tree890303d36d32360a13f4d433c7fd7daeb5690b74 /tests
parent422a74df58301a13f20d09f2337c9efe6020508b (diff)
downloadtcpdump-05169ee13227f91e656e715cfc831d416447e39f.tar.gz
address some nits after the TESTrun storm
Remove a stray .md file and restore some comments from the removed .sh files so future folk can see where the conditional tests come from, not just the mere fact of their existence. Remove the unused fragile shebang from testfuncs.pm. [skip ci]
Diffstat (limited to 'tests')
-rw-r--r--tests/crypto.tests3
-rw-r--r--tests/isis-seg-fault-1-v.tests4
-rw-r--r--tests/lmp-v.tests6
-rw-r--r--tests/testfuncs.pm2
4 files changed, 14 insertions, 1 deletions
diff --git a/tests/crypto.tests b/tests/crypto.tests
index f0ab6f3c..dc16edbd 100644
--- a/tests/crypto.tests
+++ b/tests/crypto.tests
@@ -1,5 +1,8 @@
# -*- perl -*-
+# Only attempt OpenSSL-specific tests when compiled with the library.
+# Reading the secret(s) from a file does not work with Capsicum.
+
$testlist = [
{
config_set => 'HAVE_LIBCRYPTO',
diff --git a/tests/isis-seg-fault-1-v.tests b/tests/isis-seg-fault-1-v.tests
index b19d6dac..f90fc4a7 100644
--- a/tests/isis-seg-fault-1-v.tests
+++ b/tests/isis-seg-fault-1-v.tests
@@ -1,5 +1,9 @@
# -*- perl -*-
+# This "verbose" ISIS protocol test involves a float calculation that
+# may produce a slightly different result if the compiler is not GCC.
+# Test only with GCC (similar to GitHub issue #333).
+
$testlist = [
{
config_set => 'USING_GCC',
diff --git a/tests/lmp-v.tests b/tests/lmp-v.tests
index 5fa34a70..27232512 100644
--- a/tests/lmp-v.tests
+++ b/tests/lmp-v.tests
@@ -1,5 +1,11 @@
# -*- perl -*-
+# The "verbose" Link Management Protocol test involves a float calculation that
+# may produce a slightly different result depending on the architecture and the
+# compiler (see GitHub issue #333). The reference output was produced using a
+# GCC build and must reproduce correctly on any other GCC build regardless of
+# the architecture.
+
$testlist = [
{
config_set => 'USING_GCC',
diff --git a/tests/testfuncs.pm b/tests/testfuncs.pm
index bed0d04d..aa40680f 100644
--- a/tests/testfuncs.pm
+++ b/tests/testfuncs.pm
@@ -1,4 +1,4 @@
-#!/usr/bin/perl
+# -*- perl -*-
# expects to be run from the top directory, with "tests" subdirectory.