| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
ND_TCHECK_n(e), n in { 1, 2, 3, 4, 8 }.
They are redundant because they are followed by a GET_.*_n(e) call,
same n, same e, which do the bounds check.
Remove unused 'trunc' labels and most associated codes.
Update the outputs of some tests accordingly.
|
|
|
|
|
|
|
|
|
| |
The file tests/RADIUS-RFC5580.pcap had all NTP timestamps set to
0x01234567.89abcdef seconds since year 1900, which on Linux and FreeBSD
produced "19088743.537777777 (1900-08-09T22:25:43Z)", but on Solaris 10
produced "(unrepresentable)". Increment Sighting Time by 120 nominal
years worth of seconds and make Time-to-Live and Retention Expires 12
and 48 hours later respectively.
|
|
|
|
|
|
|
|
|
| |
Use GET_ macros and C99 uint types. Use nd_printn() to print RADIUS
strings, which are not NUL-terminated (see RFC 2865 page 25). Use
p_ntp_time() to print NTP timestamps. In print_attr_location_data() print
the Location field as hex and add a comment to explain why. In
print_basic_location_policy_rules() display any non-zero MBZ bits in the
Flags field. Make output format more consistent. Update the test case.
|
| |
|
|
|
|
| |
This is a follow-up to 69a76fb67a36a19779142d07bb0cb31b7736a936.
|
|
|
|
| |
This is a follow-up to commit 1103418a18d71c0fe448c0459a42ff1bc20bb0dc.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rfc1048_print() used to print DHCP options in a few different formats
depending on the context (see GH issue #866):
* at the top of an RFC 1048 block:
* known options: [string] name and [decimal] tag
* unknown options: tag twice
* inside a Parameter Request (55) block:
* known options: name
* unknown options: tag
Change it to use the "Name (tag)" format (as in TCP, BGP, etc) in all
contexts. Update output for 8 tests.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The SRv6 network programming defines a new IP protocol number [1].
The new protocol number is used in the Next Header field of an IPv6 header
or any extension header indicates that the payload is an Ethernet.
IANA has assigned 143 as the protocol number of ethernet [2].
The SRv6 packet has the following format:
IPv6 HDR + SRH + Ethernet HDR + IPv4/IPv6 packet
This patch allows TCPDUMP to dissect such SRv6 packets.
[1] https://tools.ietf.org/html/draft-ietf-spring-srv6-network-programming-16#section-9.1
[2] https://www.iana.org/assignments/protocol-numbers/protocol-numbers.xhtml
Signed-off-by: Ahmed Abdelsalam <ahabdels@gmail.com>
|
|
|
|
|
|
| |
Moreover:
Remove trailing "_if" from some protocol names.
Update the outputs of two tests accordingly.
|
|
|
|
| |
(pull request #864)
|
| |
|
|
|
|
|
|
| |
As per IEEE std 802.1-AB-2009, 802.3 link aggregation TLV has been
deprecated and link aggregation TLV has been added as an 802.1
TLV. Support for this is given.
|
|
|
|
|
|
|
|
| |
If we don't give them definitions, in some contents they are interpreted
as strings, and 'false', being a non-empty string, is interpreted as
being true. See, for example:
https://stackoverflow.com/questions/6936194/is-there-a-built-in-true-false-boolean-value-in-perl
|
|
|
|
|
|
|
|
| |
(Matters only on Windows, and we're still not ready for the check target
to be used on Windows yet; for one thing, it requires that tcpdump be
built with the latest shiniest libpcap, to handle some capture files
that use post-1.9 LINKTYPE_ values, and we aren't yet set up to do
that.)
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We can use the POSIX functions on UN*X, but not on Windows. Use them on
UN*X, but extract the exit status manually on Windows.
Put in a pile of comments about the return status of commands, command
interpreters, and the Perl system function on UN*X and Windows.
If system simply fails to run at atll (returns -1), put a message into
the faked output file.
Get rid of some duplicate initializations while we're at it.
|
|
|
|
| |
I guess that's not allowed, at least not by fc.
|
| |
|
|
|
|
|
|
|
|
| |
DEC's decisions and the Multics developers' decisions affect us to this
day. (Unix went with the Multics use of - to indicate options; DOS went
with the DEC use of / to indicate options, so they had to use \ as the
pathname component separator, and Windows followed suit, so here we
are.)
|
|
|
|
| |
[skip ci]
|
|
|
|
| |
That makes it a bit easier to read.
|
|
|
|
| |
There's no need to treat Windows specially in that code path.
|
|
|
|
|
|
| |
Falling off the end isn't reported as an issue by the Perl interpreter
here, and doesn't appear to cause a reliable return value, so not all
failed tests are counted.
|
| |
|
|
|
|
|
|
|
| |
This is a follow-up to commit 25687e1a312a3bb63a6e8d7f0af0210a615e24a8.
These files come from the Wireshark menagerie:
0031419.pcap (link type 160) and 5632-Raw_D-BUS.cap (first two packets).
|
|
|
|
| |
diff doesn't come standard with Windows; fc does.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many Windows commands only accept paths using backslashes, because
slashes are option separators.
Add a showfile() function that takes a pathname as an argument and:
on Windows, converts the pathname to canonical form - which
means any slashes will be converted to backslashes - and run
"type" on it;
on UN*X, run "cat" on it.
Convert
cat foo | diff bar -
to
diff bar foo
to avoid using cat at all. (Note also that the closest built-in Windows
equivalent of diff, fc, does *not* support reading the standard input as
one of the files to compare, so it also will avoid that when we change
those to use fc on Windows.)
The one remaining use of cat is in a command with pathnames, so use a
type command, with backslash-separated paths, on Windows, and cat, with
slash-separated paths, on UN*X.
We might just want to do that directly in Perl; add a comment about
that.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Run tcpdump, not windump - we build it as tcpdump, not windump, and
there's not really a reason to have a separate windump program.
For now, at least, assume a Visual Studio debug build, so it's in the
Debug subdirectory.
Use that path for *all* calls to tcpdump.
Use "type" rather than "cat" to print files on Windows.
It still needs to be changed to, for example, not use sed.
|
| |
|
|
|
|
|
|
| |
Add the frame number, as we now run the tests with -#.
Fix some output to match the current state of the code.
|
|\ |
|
| |
| |
| |
| | |
Update the output file for tests.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Adapted from GitHub pull request #798.
Print " (invalid)" when combinations of V-Flag and L-Flag are invalid.
Update comments (draft -> RFC).
Remove some ND_TCHECK_LEN because GET_ use.
Update the output of isis_sid test because commit
b09710dfcdd50251efd487e800cd1b9fd01eaf96 updated the output format
of the IS-IS dissector.
|
| |\
| | |
| | | |
Fix and update 802.11 reason codes
|
| | | |
|
| |\ \
| | | |
| | | | |
Fix and update 802.11 status codes
|
| | |/ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Adapted from GitHub pull request #768, with some cleanups and an
additional test update to handle the addition of the Unicast flag to the
Hello TLV.
Added a list of RFCs and I-Ds.
|
| | |
| | |
| | |
| | |
| | |
| | | |
As described in RFC4684, prefix lengths of 0 and
32-96 are all valid. Introduce bgp_rt_prefix_print()
to print partial route targets.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Moreover:
Update the protocol names (sl_if -> slip and sl_bsdos_if -> slip_bsdos).
Update the output of some tests accordingly.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fix was: "SLIP: Add some bounds checks"
(commit bbe15da782ef74dd29feea6e3ea0f2f7d47b4697)
The pcap files were updated to avoid pcap_loop() error messages.
|
| | | |
|
| | |
| | |
| | |
| | | |
This is a follow-up to the previous commit.
|
| | |
| | |
| | |
| | |
| | |
| | | |
(pull request #808)
Format of EDNS options matches format of TCP options.
|
| | |
| | |
| | |
| | | |
(pull request #762)
|
| | |
| | |
| | |
| | | |
(pull request #845)
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
(pull request #843)
fix build break for Broadcom LI printer on BSD platforms
incorporate review comments: make bcm_li_print() void, add a sample capture
incorporate review comments: remove trailing tabs
add BCM LI outputs to testset
incorporate review comment: return after printing
update verbose output for bcm-li
|
| | |
| | |
| | |
| | |
| | |
| | | |
Moreover:
Remove trailing "_if" from protocol name.
Update the output of a test accordingly.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Rename ip_print_demux() to ip_demux_print(), with _print suffix like
in most similar cases.
Moreover:
Rename a test.
|
| | |
| | |
| | |
| | |
| | |
| | | |
This allows tcpdump to handle DNS running on non-standard ports.
Add two test files with DNS over TCP and DNS over UDP, port 8053.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
RFC6824bis-18 (MPTCP version 1) makes changes to the MPTCP
ADD_ADDR option format.
An HMAC field is added to the option and the IP version field is
removed and replaced with an Echo bit that provides a reliability
mechanism.
This change allows either v0 or v1 ADD_ADDR options
to be parsed and displayed correctly.
Signed-off-by: Peter Krystad <peter.krystad@linux.intel.com>
|