diff options
| author | Toshio Kuratomi <toshio@fedoraproject.org> | 2015-03-26 11:42:08 -0700 |
|---|---|---|
| committer | Toshio Kuratomi <toshio@fedoraproject.org> | 2015-03-26 11:42:56 -0700 |
| commit | 400166a655b304094005aace178d0fab1cfe9763 (patch) | |
| tree | cdd5d9aacf1af5b3d2eafb89bc5737243df3abb5 /database/mysql/mysql_replication.py | |
| parent | 2b192c7f8e0c99830b2beabc977ace5963c5ebc1 (diff) | |
| download | ansible-modules-extras-400166a655b304094005aace178d0fab1cfe9763.tar.gz | |
Port is an integer so use arg_spec to enforce that.
Diffstat (limited to 'database/mysql/mysql_replication.py')
| -rw-r--r-- | database/mysql/mysql_replication.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/database/mysql/mysql_replication.py b/database/mysql/mysql_replication.py index 07d09602..30811cdc 100644 --- a/database/mysql/mysql_replication.py +++ b/database/mysql/mysql_replication.py @@ -239,7 +239,7 @@ def main(): login_user=dict(default=None), login_password=dict(default=None), login_host=dict(default="localhost"), - login_port=dict(default="3306"), + login_port=dict(default=3306, type='int'), login_unix_socket=dict(default=None), mode=dict(default="getslave", choices=["getmaster", "getslave", "changemaster", "stopslave", "startslave"]), master_host=dict(default=None), @@ -304,10 +304,10 @@ def main(): try: if module.params["login_unix_socket"]: db_connection = MySQLdb.connect(host=module.params["login_host"], unix_socket=module.params["login_unix_socket"], user=login_user, passwd=login_password) - elif module.params["login_port"] != "3306" and module.params["login_host"] == "localhost": + elif module.params["login_port"] != 3306 and module.params["login_host"] == "localhost": module.fail_json(msg="login_host is required when login_port is defined, login_host cannot be localhost when login_port is defined") else: - db_connection = MySQLdb.connect(host=module.params["login_host"], port=int(module.params["login_port"]), user=login_user, passwd=login_password) + db_connection = MySQLdb.connect(host=module.params["login_host"], port=module.params["login_port"], user=login_user, passwd=login_password) except Exception, e: module.fail_json(msg="unable to connect to database, check login_user and login_password are correct or ~/.my.cnf has the credentials") try: |