Bug # 51154: cppunit warning cleaning

This patch allows to compile the code with gcc's -Weffc++

It consists mostly of making copy constructors and assignment operators
explicit and private, and of initializing all members in initializer lists.

Change-Id: I6f1cae812c58e3791c2386a1288501cf2f559610
Reviewed-on: https://gerrit.libreoffice.org/5424
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>

1 files changed, 6 insertions, 6 deletions

diff --git a/src/cppunit/Message.cpp b/src/cppunit/Message.cpp
index 955a381..ad2efd9 100644
--- a/src/cppunit/Message.cpp
+++ b/src/cppunit/Message.cpp
@@ -4,19 +4,16 @@
 
 CPPUNIT_NS_BEGIN
 
-
-Message::Message()
-{
-}
-
 Message::Message( const Message &other )
+    : m_shortDescription()
+    , m_details()
 {
    *this = other;
 }
 
-
 Message::Message( const std::string &shortDescription )
     : m_shortDescription( shortDescription )
+    , m_details()
 {
 }
 
@@ -24,6 +21,7 @@ Message::Message( const std::string &shortDescription )
 Message::Message( const std::string &shortDescription,
                   const std::string &detail1 )
     : m_shortDescription( shortDescription )
+    , m_details()
 {
   addDetail( detail1 );
 }
@@ -33,6 +31,7 @@ Message::Message( const std::string &shortDescription,
                   const std::string &detail1,
                   const std::string &detail2 )
     : m_shortDescription( shortDescription )
+    , m_details()
 {
   addDetail( detail1, detail2 );
 }
@@ -43,6 +42,7 @@ Message::Message( const std::string &shortDescription,
                   const std::string &detail2,
                   const std::string &detail3 )
     : m_shortDescription( shortDescription )
+    , m_details()
 {
   addDetail( detail1, detail2, detail3 );
 }