summaryrefslogtreecommitdiff
path: root/README.md
diff options
context:
space:
mode:
authorJacob Vosmaer <jacob@gitlab.com>2019-04-03 12:35:25 +0000
committerNick Thomas <nick@gitlab.com>2019-04-03 12:35:25 +0000
commite0824f17367a44e5bac84dac7197f9b45e37ab01 (patch)
tree035d1ddb8bcef59e91576d42efc1dbd8824adc9d /README.md
parent433cc96551a6d1f1621f9e105b1e7eb1ccc41b7a (diff)
downloadgitlab-shell-e0824f17367a44e5bac84dac7197f9b45e37ab01.tar.gz
Remove hooks, they belong to Gitaly now
Diffstat (limited to 'README.md')
-rw-r--r--README.md8
1 files changed, 2 insertions, 6 deletions
diff --git a/README.md b/README.md
index 7cb9619..5bd0024 100644
--- a/README.md
+++ b/README.md
@@ -20,7 +20,7 @@ An overview of the four cases described above:
## Git hooks
-For historical reasons the gitlab-shell repository also contains the
+The gitlab-shell repository used to also contain the
Git hooks that allow GitLab to validate Git pushes (e.g. "is this user
allowed to push to this protected branch"). These hooks also trigger
events in GitLab (e.g. to start a CI pipeline after a push).
@@ -30,17 +30,13 @@ require direct disk access to Git repositories, and that is only
possible on Gitaly servers. It makes no sense to have to install
gitlab-shell on Gitaly servers.
-As of GitLab 11.9 [the actual Git hooks are in the Gitaly
+As of GitLab 11.10 [the actual Git hooks are in the Gitaly
repository](https://gitlab.com/gitlab-org/gitaly/tree/v1.22.0/ruby/vendor/gitlab-shell/hooks),
but gitlab-shell must still be installed on Gitaly servers because the
hooks rely on configuration data (e.g. the GitLab internal API URL) that
is not yet available in Gitaly itself. Also see the [transition
plan](https://gitlab.com/gitlab-org/gitaly/issues/1226#note_126519133).
-This means that for GitLab 11.9 and up, it is pointless to make changes
-to Git hook code in the gitlab-shell repository, because the code that
-gets run is in the Gitaly repository instead.
-
## Code status
[![pipeline status](https://gitlab.com/gitlab-org/gitlab-shell/badges/master/pipeline.svg)](https://gitlab.com/gitlab-org/gitlab-shell/commits/master)