summaryrefslogtreecommitdiff
path: root/client/client_test.go
diff options
context:
space:
mode:
authorAlejandro Rodríguez <alejorro70@gmail.com>2022-06-30 21:37:31 +0200
committerAlejandro Rodríguez <alejorro70@gmail.com>2022-06-30 22:27:33 +0200
commit9b60ce49460876d0e599f2fec65f02856930dbcd (patch)
tree9179705f9e8b6ee309d456323fbaedaa70141c7e /client/client_test.go
parent01f4e022c04b29b896eb383e6e6a33f96a6beeb1 (diff)
downloadgitlab-shell-9b60ce49460876d0e599f2fec65f02856930dbcd.tar.gz
Pass original IP from PROXY requests to internal API calls
Diffstat (limited to 'client/client_test.go')
-rw-r--r--client/client_test.go22
1 files changed, 22 insertions, 0 deletions
diff --git a/client/client_test.go b/client/client_test.go
index 66ce2d8..06036b6 100644
--- a/client/client_test.go
+++ b/client/client_test.go
@@ -76,6 +76,7 @@ func TestClients(t *testing.T) {
testErrorMessage(t, client)
testAuthenticationHeader(t, client)
testJWTAuthenticationHeader(t, client)
+ testXForwardedForHeader(t, client)
})
}
}
@@ -221,6 +222,21 @@ func testJWTAuthenticationHeader(t *testing.T, client *GitlabNetClient) {
})
}
+func testXForwardedForHeader(t *testing.T, client *GitlabNetClient) {
+ t.Run("X-Forwarded-For Header inserted if original address in context", func(t *testing.T) {
+ ctx := context.WithValue(context.Background(), OriginalRemoteIPContextKey{}, "196.7.0.238")
+ response, err := client.Get(ctx, "/x_forwarded_for")
+ require.NoError(t, err)
+ require.NotNil(t, response)
+
+ defer response.Body.Close()
+
+ responseBody, err := io.ReadAll(response.Body)
+ require.NoError(t, err)
+ require.Equal(t, "196.7.0.238", string(responseBody))
+ })
+}
+
func buildRequests(t *testing.T, relativeURLRoot string) []testserver.TestRequestHandler {
requests := []testserver.TestRequestHandler{
{
@@ -257,6 +273,12 @@ func buildRequests(t *testing.T, relativeURLRoot string) []testserver.TestReques
},
},
{
+ Path: "/api/v4/internal/x_forwarded_for",
+ Handler: func(w http.ResponseWriter, r *http.Request) {
+ fmt.Fprint(w, r.Header.Get("X-Forwarded-For"))
+ },
+ },
+ {
Path: "/api/v4/internal/error",
Handler: func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")