summaryrefslogtreecommitdiff
path: root/go/internal/command/fallback/fallback_test.go
diff options
context:
space:
mode:
authorPatrick Bajao <ebajao@gitlab.com>2019-07-29 14:33:01 +0800
committerPatrick Bajao <ebajao@gitlab.com>2019-07-29 14:58:32 +0800
commitaab85f3600caf04b491d6ca4fc3f0f004d9e3fc0 (patch)
treeda3f6ab04de4e0c1ba5b79a281c6ca91852e0aa1 /go/internal/command/fallback/fallback_test.go
parented0460374a5ca13d9ea17c6a9c21151319b7fd53 (diff)
downloadgitlab-shell-aab85f3600caf04b491d6ca4fc3f0f004d9e3fc0.tar.gz
Support falling back to ruby version of checkers
Rename the ruby scripts to have `-ruby` suffix and add a symlink for both to `./gitlab-shell`. The executable name will be used to determine how args will be parsed. For now, we only parse the arguments for gitlab-shell commands. If the executable is `gitlab-shell-authorized-keys-check` or `gitlab-shell-authorized-principals-check`, it'll always fallback to the ruby version. Ruby specs test the ruby script, the fallback from go to ruby and go implementation of both (still pending).
Diffstat (limited to 'go/internal/command/fallback/fallback_test.go')
-rw-r--r--go/internal/command/fallback/fallback_test.go17
1 files changed, 16 insertions, 1 deletions
diff --git a/go/internal/command/fallback/fallback_test.go b/go/internal/command/fallback/fallback_test.go
index afd752b..91dcb53 100644
--- a/go/internal/command/fallback/fallback_test.go
+++ b/go/internal/command/fallback/fallback_test.go
@@ -6,6 +6,8 @@ import (
"testing"
"github.com/stretchr/testify/require"
+
+ "gitlab.com/gitlab-org/gitlab-shell/go/internal/command/commandargs"
)
type fakeExec struct {
@@ -18,8 +20,21 @@ type fakeExec struct {
Env []string
}
+type FakeCommandArgs struct {
+ executable commandargs.Executable
+ arguments []string
+}
+
+func (f *FakeCommandArgs) Executable() commandargs.Executable {
+ return f.executable
+}
+
+func (f *FakeCommandArgs) Arguments() []string {
+ return f.arguments
+}
+
var (
- fakeArgs = []string{"./test", "foo", "bar"}
+ fakeArgs = &FakeCommandArgs{executable: commandargs.GitlabShell, arguments: []string{"foo", "bar"}}
)
func (f *fakeExec) Exec(filename string, args []string, env []string) error {