diff options
| author | Małgorzata Ksionek <mksionek@gitlab.com> | 2019-09-19 12:36:53 +0200 |
|---|---|---|
| committer | Małgorzata Ksionek <mksionek@gitlab.com> | 2019-09-26 12:26:53 +0200 |
| commit | 216bfafb4c0001a476e5ca630cd8c3baf7718d8d (patch) | |
| tree | e84d1c3a906cea89f75e8564b422632fa0d75d93 /go/internal/gitlabnet/client_test.go | |
| parent | 7f0f6e7621cbc60504f0c1f1bf1541d5b95a4ff8 (diff) | |
| download | gitlab-shell-216bfafb4c0001a476e5ca630cd8c3baf7718d8d.tar.gz | |
Add code review remarks
Diffstat (limited to 'go/internal/gitlabnet/client_test.go')
| -rw-r--r-- | go/internal/gitlabnet/client_test.go | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/go/internal/gitlabnet/client_test.go b/go/internal/gitlabnet/client_test.go index debe618..07ac7b8 100644 --- a/go/internal/gitlabnet/client_test.go +++ b/go/internal/gitlabnet/client_test.go @@ -55,7 +55,7 @@ func TestClients(t *testing.T) { Path: "/api/v4/internal/with_ip", Handler: func(w http.ResponseWriter, r *http.Request) { header := r.Header.Get("X_FORWARDED_FOR") - require.Equal(t, header, "127.0.0.1") + require.Equal(t, "127.0.0.1", header) }, }, { @@ -229,21 +229,23 @@ func testAuthenticationHeader(t *testing.T, client *GitlabClient) { func testXForwardedForHeader(t *testing.T, client *GitlabClient) { t.Run("X-Forwarded-For for GET", func(t *testing.T) { - os.Setenv("SSH_CONNECTION", "127.0.0.1 0") + err := os.Setenv("SSH_CONNECTION", "127.0.0.1 0") + require.Nil(t, err) + response, err := client.Get("/with_ip") - defer response.Body.Close() require.NoError(t, err) require.NotNil(t, response) + response.Body.Close() }) t.Run("X-Forwarded-For for POST", func(t *testing.T) { data := map[string]string{"key": "value"} os.Setenv("SSH_CONNECTION", "127.0.0.1 0") response, err := client.Post("/with_ip", data) - defer response.Body.Close() require.NoError(t, err) require.NotNil(t, response) + response.Body.Close() }) } |