diff options
author | Małgorzata Ksionek <mksionek@gitlab.com> | 2019-09-30 10:36:35 +0200 |
---|---|---|
committer | Małgorzata Ksionek <mksionek@gitlab.com> | 2019-09-30 10:36:35 +0200 |
commit | 650ecad9bad69dbc12745c71d959a89b87ffdac7 (patch) | |
tree | 1d1a7c136be4867e536db2a476a47ad713b30f73 /go/internal/gitlabnet | |
parent | 9304b1d6110494147ff7113592d8473ecb3e9114 (diff) | |
download | gitlab-shell-650ecad9bad69dbc12745c71d959a89b87ffdac7.tar.gz |
Clean up files
Diffstat (limited to 'go/internal/gitlabnet')
-rw-r--r-- | go/internal/gitlabnet/client_test.go | 28 |
1 files changed, 28 insertions, 0 deletions
diff --git a/go/internal/gitlabnet/client_test.go b/go/internal/gitlabnet/client_test.go index e813e23..f4ab62f 100644 --- a/go/internal/gitlabnet/client_test.go +++ b/go/internal/gitlabnet/client_test.go @@ -58,6 +58,13 @@ func TestClients(t *testing.T) { }, }, { + Path: "/api/v4/internal/with_empty_ip", + Handler: func(w http.ResponseWriter, r *http.Request) { + header := r.Header.Get("X-Forwarded-For") + require.Equal(t, "", header) + }, + }, + { Path: "/api/v4/internal/error", Handler: func(w http.ResponseWriter, r *http.Request) { w.Header().Set("Content-Type", "application/json") @@ -107,6 +114,7 @@ func TestClients(t *testing.T) { tc.config.GitlabUrl = url tc.config.Secret = "sssh, it's a secret" + client, err := GetClient(tc.config) require.NoError(t, err) @@ -117,6 +125,7 @@ func TestClients(t *testing.T) { testErrorMessage(t, client) testAuthenticationHeader(t, client) testXForwardedForHeader(t, client) + testEmptyForwardedForHeader(t, client) }) } } @@ -251,3 +260,22 @@ func testXForwardedForHeader(t *testing.T, client *GitlabClient) { response.Body.Close() }) } + +func testEmptyForwardedForHeader(t *testing.T, client *GitlabClient) { + t.Run("X-Forwarded-For empty for GET", func(t *testing.T) { + response, err := client.Get("/with_empty_ip") + + require.NoError(t, err) + require.NotNil(t, response) + response.Body.Close() + }) + + t.Run("X-Forwarded-For empty for POST", func(t *testing.T) { + data := map[string]string{"key": "value"} + response, err := client.Post("/with_empty_ip", data) + + require.NoError(t, err) + require.NotNil(t, response) + response.Body.Close() + }) +} |