diff options
author | Andrew Newdigate <andrew@gitlab.com> | 2019-02-25 16:19:08 +0200 |
---|---|---|
committer | Andrew Newdigate <andrew@gitlab.com> | 2019-03-01 15:07:23 +0200 |
commit | 210a5c141c9d76bc9718860d67d77d73997b1534 (patch) | |
tree | e8bfe028d6ecb5ddc269b67283b7b52240323dde /go/internal/handler/upload_pack.go | |
parent | 070691c29891c27f0e46f86f6c89566199ccc54b (diff) | |
download | gitlab-shell-an-distributed-tracing.tar.gz |
Adds distributed tracing instrumentation to GitLab-Shellan-distributed-tracing
Adds distributed tracing instrumentation to GitLab-Shell using LabKit
Diffstat (limited to 'go/internal/handler/upload_pack.go')
-rw-r--r-- | go/internal/handler/upload_pack.go | 18 |
1 files changed, 5 insertions, 13 deletions
diff --git a/go/internal/handler/upload_pack.go b/go/internal/handler/upload_pack.go index dd146fb..1ce5ea3 100644 --- a/go/internal/handler/upload_pack.go +++ b/go/internal/handler/upload_pack.go @@ -2,25 +2,17 @@ package handler import ( "context" - "fmt" "os" pb "gitlab.com/gitlab-org/gitaly-proto/go/gitalypb" "gitlab.com/gitlab-org/gitaly/client" + "google.golang.org/grpc" ) -func UploadPack(gitalyAddress string, request *pb.SSHUploadPackRequest) (int32, error) { - if gitalyAddress == "" { - return 0, fmt.Errorf("no gitaly_address given") - } - - conn, err := client.Dial(gitalyAddress, dialOpts()) - if err != nil { - return 0, err - } - defer conn.Close() - - ctx, cancel := context.WithCancel(context.Background()) +// UploadPack issues a Gitaly upload-pack rpc to the provided address +func UploadPack(ctx context.Context, conn *grpc.ClientConn, request *pb.SSHUploadPackRequest) (int32, error) { + ctx, cancel := context.WithCancel(ctx) defer cancel() + return client.UploadPack(ctx, conn, os.Stdin, os.Stdout, os.Stderr, request) } |