summaryrefslogtreecommitdiff
path: root/internal/command/healthcheck/healthcheck_test.go
diff options
context:
space:
mode:
authorIgor Drozdov <idrozdov@gitlab.com>2021-03-17 21:18:42 +0300
committerIgor Drozdov <idrozdov@gitlab.com>2021-03-17 21:23:07 +0300
commitee41d0dfb7b02a19f5926bfe24dbad1df417a29e (patch)
tree130f2777342645018f3f6b797ee0083d65910889 /internal/command/healthcheck/healthcheck_test.go
parent4b40a2cb8c71a5b490cad4c8e1ad2dc0e9b39548 (diff)
downloadgitlab-shell-ee41d0dfb7b02a19f5926bfe24dbad1df417a29e.tar.gz
Replace cleanup functions with t.Cleanup
In this case we don't need to propagate cleanup function. It simplifies the code.
Diffstat (limited to 'internal/command/healthcheck/healthcheck_test.go')
-rw-r--r--internal/command/healthcheck/healthcheck_test.go9
1 files changed, 3 insertions, 6 deletions
diff --git a/internal/command/healthcheck/healthcheck_test.go b/internal/command/healthcheck/healthcheck_test.go
index d05e563..c010c17 100644
--- a/internal/command/healthcheck/healthcheck_test.go
+++ b/internal/command/healthcheck/healthcheck_test.go
@@ -45,8 +45,7 @@ func buildTestHandlers(code int, rsp *healthcheck.Response) []testserver.TestReq
}
func TestExecute(t *testing.T) {
- url, cleanup := testserver.StartSocketHttpServer(t, okHandlers)
- defer cleanup()
+ url := testserver.StartSocketHttpServer(t, okHandlers)
buffer := &bytes.Buffer{}
cmd := &Command{
@@ -61,8 +60,7 @@ func TestExecute(t *testing.T) {
}
func TestFailingRedisExecute(t *testing.T) {
- url, cleanup := testserver.StartSocketHttpServer(t, badRedisHandlers)
- defer cleanup()
+ url := testserver.StartSocketHttpServer(t, badRedisHandlers)
buffer := &bytes.Buffer{}
cmd := &Command{
@@ -76,8 +74,7 @@ func TestFailingRedisExecute(t *testing.T) {
}
func TestFailingAPIExecute(t *testing.T) {
- url, cleanup := testserver.StartSocketHttpServer(t, brokenHandlers)
- defer cleanup()
+ url := testserver.StartSocketHttpServer(t, brokenHandlers)
buffer := &bytes.Buffer{}
cmd := &Command{