diff options
| author | Nick Thomas <nick@gitlab.com> | 2021-10-13 15:22:11 +0100 |
|---|---|---|
| committer | Nick Thomas <nick@gitlab.com> | 2021-10-13 15:28:31 +0100 |
| commit | 34fa7eb3499c0f85c8610f89c120c1b3c56c1462 (patch) | |
| tree | e721100bcd86f394c6f13df5015d78126d005785 /internal/command/personalaccesstoken | |
| parent | d868b40ae666a11749ee9ec652441221197a2670 (diff) | |
| download | gitlab-shell-499-log-non-git-commands.tar.gz | |
Improve logging for non-git commands499-log-non-git-commands
Several of our commands only touch the internal API, and go nowhere
near Gitaly. Improve logging for each of these in a single MR. In
general, we want to be able to tell what happened in the execution of
each command, and to track failures down to a specific line of code.
Changelog: added
Diffstat (limited to 'internal/command/personalaccesstoken')
| -rw-r--r-- | internal/command/personalaccesstoken/personalaccesstoken.go | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/internal/command/personalaccesstoken/personalaccesstoken.go b/internal/command/personalaccesstoken/personalaccesstoken.go index 6f3d03e..1942ade 100644 --- a/internal/command/personalaccesstoken/personalaccesstoken.go +++ b/internal/command/personalaccesstoken/personalaccesstoken.go @@ -8,6 +8,8 @@ import ( "strings" "time" + "gitlab.com/gitlab-org/labkit/log" + "gitlab.com/gitlab-org/gitlab-shell/internal/command/commandargs" "gitlab.com/gitlab-org/gitlab-shell/internal/command/readwriter" "gitlab.com/gitlab-org/gitlab-shell/internal/config" @@ -38,6 +40,10 @@ func (c *Command) Execute(ctx context.Context) error { return err } + log.WithContextFields(ctx, log.Fields{ + "token_args": c.TokenArgs, + }).Info("personalaccesstoken: execute: requesting token") + response, err := c.getPersonalAccessToken(ctx) if err != nil { return err |