diff options
| author | Igor Drozdov <idrozdov@gitlab.com> | 2022-02-18 13:10:38 +0300 |
|---|---|---|
| committer | Igor Drozdov <idrozdov@gitlab.com> | 2022-03-07 16:54:15 +0300 |
| commit | e1ddbdd161a28ff53ca4d3b3f0fc4fa19687d80b (patch) | |
| tree | 9427a8f7add05d0eece7df0c48638209bea88d8d /internal/command/uploadarchive | |
| parent | ede95ae77b591fdffab6ea1f7b1c01e4402af2e1 (diff) | |
| download | gitlab-shell-e1ddbdd161a28ff53ca4d3b3f0fc4fa19687d80b.tar.gz | |
Reuse Gitaly conns and Sidechannel
When gitlab-sshd has been introduced we've started running our
own SSH server. In this case we're able to cache and reuse
Gitaly connections and Registry.
It helps to reduce memory usage.
Diffstat (limited to 'internal/command/uploadarchive')
| -rw-r--r-- | internal/command/uploadarchive/gitalycall.go | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/internal/command/uploadarchive/gitalycall.go b/internal/command/uploadarchive/gitalycall.go index 33f0b71..6051d2c 100644 --- a/internal/command/uploadarchive/gitalycall.go +++ b/internal/command/uploadarchive/gitalycall.go @@ -13,18 +13,12 @@ import ( ) func (c *Command) performGitalyCall(ctx context.Context, response *accessverifier.Response) error { - gc := &handler.GitalyCommand{ - Config: c.Config, - ServiceName: string(commandargs.UploadArchive), - Address: response.Gitaly.Address, - Token: response.Gitaly.Token, - Features: response.Gitaly.Features, - } + gc := handler.NewGitalyCommand(c.Config, string(commandargs.UploadArchive), response) request := &pb.SSHUploadArchiveRequest{Repository: &response.Gitaly.Repo} - return gc.RunGitalyCommand(ctx, func(ctx context.Context, conn *grpc.ClientConn, registry *client.SidechannelRegistry) (int32, error) { - ctx, cancel := gc.PrepareContext(ctx, request.Repository, response, c.Args.Env) + return gc.RunGitalyCommand(ctx, func(ctx context.Context, conn *grpc.ClientConn) (int32, error) { + ctx, cancel := gc.PrepareContext(ctx, request.Repository, c.Args.Env) defer cancel() rw := c.ReadWriter |