diff options
author | Alejandro RodrÃguez <alejorro70@gmail.com> | 2017-07-03 11:00:18 -0400 |
---|---|---|
committer | Alejandro RodrÃguez <alejorro70@gmail.com> | 2017-07-03 11:00:18 -0400 |
commit | c6ed2b058b5ab5fb435114491889676732aefcb2 (patch) | |
tree | 4cf184d4559cf0d7b10e8937c9fd93ee825de562 /lib | |
parent | 4539a066ecd2c5a16cab66f9e85f8f0ab747fc5f (diff) | |
download | gitlab-shell-revert-gl-repository.tar.gz |
Revert "Merge branch '86-follow-up-from-use-gl_repository-if-present-when-enqueing-sidekiq-postreceive-jobs' into 'master'"revert-gl-repository
This reverts commit fa6343515ba65423e9de4c98c6005facc6059938, reversing
changes made to 62af7f6af72728cecb98c5275d8b7aeb3953e564.
Diffstat (limited to 'lib')
-rw-r--r-- | lib/gitlab_net.rb | 13 | ||||
-rw-r--r-- | lib/gitlab_post_receive.rb | 9 |
2 files changed, 12 insertions, 10 deletions
diff --git a/lib/gitlab_net.rb b/lib/gitlab_net.rb index d0bc0bc..fad06d6 100644 --- a/lib/gitlab_net.rb +++ b/lib/gitlab_net.rb @@ -67,13 +67,11 @@ class GitlabNet JSON.parse(resp.body) rescue {} end - def merge_request_urls(gl_repository, changes) + def merge_request_urls(gl_repository, repo_path, changes) changes = changes.join("\n") unless changes.kind_of?(String) changes = changes.encode('UTF-8', 'ASCII', invalid: :replace, replace: '') - url = "#{host}/merge_request_urls?" \ - "gl_repository=#{URI.escape(gl_repository)}&" \ - "changes=#{URI.escape(changes)}" - + url = "#{host}/merge_request_urls?project=#{URI.escape(repo_path)}&changes=#{URI.escape(changes)}" + url += "&gl_repository=#{URI.escape(gl_repository)}" if gl_repository resp = get(url) JSON.parse(resp.body) rescue [] end @@ -98,8 +96,9 @@ class GitlabNet {} end - def notify_post_receive(gl_repository) - resp = post("#{host}/notify_post_receive", gl_repository: gl_repository) + def notify_post_receive(gl_repository, repo_path) + params = { gl_repository: gl_repository, project: repo_path } + resp = post("#{host}/notify_post_receive", params) resp.code == '200' rescue diff --git a/lib/gitlab_post_receive.rb b/lib/gitlab_post_receive.rb index ac2ee5e..00a1b1b 100644 --- a/lib/gitlab_post_receive.rb +++ b/lib/gitlab_post_receive.rb @@ -33,11 +33,11 @@ class GitlabPostReceive end merge_request_urls = GitlabMetrics.measure("merge-request-urls") do - api.merge_request_urls(gl_repository, changes) + api.merge_request_urls(@gl_repository, @repo_path, @changes) end print_merge_request_links(merge_request_urls) - api.notify_post_receive(gl_repository) + api.notify_post_receive(gl_repository, repo_path) rescue GitlabNet::ApiUnreachableError nil end @@ -107,11 +107,14 @@ class GitlabPostReceive def update_redis # Encode changes as base64 so we don't run into trouble with non-UTF-8 input. changes = Base64.encode64(@changes) + # TODO: Change to `@gl_repository` in next release. + # See https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/130#note_28747613 + project_identifier = @gl_repository || @repo_path queue = "#{config.redis_namespace}:queue:post_receive" msg = JSON.dump({ 'class' => 'PostReceive', - 'args' => [@gl_repository, @actor, changes], + 'args' => [project_identifier, @actor, changes], 'jid' => @jid, 'enqueued_at' => Time.now.to_f }) |