diff options
| -rw-r--r-- | README.md | 21 |
1 files changed, 17 insertions, 4 deletions
@@ -23,10 +23,23 @@ An overview of the four cases described above: For historical reasons the gitlab-shell repository also contains the Git hooks that allow GitLab to validate Git pushes (e.g. "is this user allowed to push to this protected branch"). These hooks also trigger -events in GitLab (e.g. to start a CI pipeline after a push). In -GitLab's current architecture (Q4 2018) these hooks belong to Gitaly -more than gitlab-shell. We [are moving them to the Gitaly -repository](https://gitlab.com/gitlab-org/gitaly/issues/1226). +events in GitLab (e.g. to start a CI pipeline after a push). + +We are in the process of moving these hooks to Gitaly, because Git hooks +require direct disk access to Git repositories, and that is only +possible on Gitaly servers. It makes no sense to have to install +gitlab-shell on Gitaly servers. + +As of GitLab 11.9 [the actual Git hooks are in the Gitaly +repository](https://gitlab.com/gitlab-org/gitaly/tree/v1.22.0/ruby/vendor/gitlab-shell/hooks), +but gitlab-shell must still be installed on Gitaly servers because the +hooks rely on configuration data (e.g. the GitLab internal API URL) that +is not yet available in Gitaly itself. Also see the [transition +plan](https://gitlab.com/gitlab-org/gitaly/issues/1226#note_126519133). + +This means that for GitLab 11.9 and up, it is pointless to make changes +to Git hook code in the gitlab-shell repository, because the code that +gets run is in the Gitaly repository instead. ## Code status |