summaryrefslogtreecommitdiff
path: root/go/internal/command
diff options
context:
space:
mode:
Diffstat (limited to 'go/internal/command')
-rw-r--r--go/internal/command/command.go2
-rw-r--r--go/internal/command/fallback/fallback.go23
-rw-r--r--go/internal/command/fallback/fallback_test.go75
3 files changed, 93 insertions, 7 deletions
diff --git a/go/internal/command/command.go b/go/internal/command/command.go
index b3bdcba..560e0b2 100644
--- a/go/internal/command/command.go
+++ b/go/internal/command/command.go
@@ -24,7 +24,7 @@ func New(arguments []string, config *config.Config) (Command, error) {
return buildCommand(args, config), nil
}
- return &fallback.Command{}, nil
+ return &fallback.Command{RootDir: config.RootDir, Args: arguments}, nil
}
func buildCommand(args *commandargs.CommandArgs, config *config.Config) Command {
diff --git a/go/internal/command/fallback/fallback.go b/go/internal/command/fallback/fallback.go
index 6e6d526..71e2a98 100644
--- a/go/internal/command/fallback/fallback.go
+++ b/go/internal/command/fallback/fallback.go
@@ -8,14 +8,25 @@ import (
"gitlab.com/gitlab-org/gitlab-shell/go/internal/command/readwriter"
)
-type Command struct{}
+type Command struct {
+ RootDir string
+ Args []string
+}
var (
- binDir = filepath.Dir(os.Args[0])
+ // execFunc is overridden in tests
+ execFunc = syscall.Exec
+)
+
+const (
+ RubyProgram = "gitlab-shell-ruby"
)
-func (c *Command) Execute(_ *readwriter.ReadWriter) error {
- rubyCmd := filepath.Join(binDir, "gitlab-shell-ruby")
- execErr := syscall.Exec(rubyCmd, os.Args, os.Environ())
- return execErr
+func (c *Command) Execute(*readwriter.ReadWriter) error {
+ rubyCmd := filepath.Join(c.RootDir, "bin", RubyProgram)
+
+ // Ensure rubyArgs[0] is the full path to gitlab-shell-ruby
+ rubyArgs := append([]string{rubyCmd}, c.Args[1:]...)
+
+ return execFunc(rubyCmd, rubyArgs, os.Environ())
}
diff --git a/go/internal/command/fallback/fallback_test.go b/go/internal/command/fallback/fallback_test.go
new file mode 100644
index 0000000..2d67b14
--- /dev/null
+++ b/go/internal/command/fallback/fallback_test.go
@@ -0,0 +1,75 @@
+package fallback
+
+import (
+ "errors"
+ "os"
+ "testing"
+
+ "github.com/stretchr/testify/require"
+)
+
+type fakeExec struct {
+ OldExec func(string, []string, []string) error
+ Error error
+ Called bool
+
+ Filename string
+ Args []string
+ Env []string
+}
+
+var (
+ fakeArgs = []string{"./test", "foo", "bar"}
+)
+
+func (f *fakeExec) Exec(filename string, args []string, env []string) error {
+ f.Called = true
+
+ f.Filename = filename
+ f.Args = args
+ f.Env = env
+
+ return f.Error
+}
+
+func (f *fakeExec) Setup() {
+ f.OldExec = execFunc
+ execFunc = f.Exec
+}
+
+func (f *fakeExec) Cleanup() {
+ execFunc = f.OldExec
+}
+
+func TestExecuteExecsCommandSuccesfully(t *testing.T) {
+ cmd := &Command{RootDir: "/tmp", Args: fakeArgs}
+
+ // Override the exec func
+ fake := &fakeExec{}
+ fake.Setup()
+ defer fake.Cleanup()
+
+ require.NoError(t, cmd.Execute(nil))
+ require.True(t, fake.Called)
+ require.Equal(t, fake.Filename, "/tmp/bin/gitlab-shell-ruby")
+ require.Equal(t, fake.Args, []string{"/tmp/bin/gitlab-shell-ruby", "foo", "bar"})
+ require.Equal(t, fake.Env, os.Environ())
+}
+
+func TestExecuteExecsCommandOnError(t *testing.T) {
+ cmd := &Command{RootDir: "/test", Args: fakeArgs}
+
+ // Override the exec func
+ fake := &fakeExec{Error: errors.New("Test error")}
+ fake.Setup()
+ defer fake.Cleanup()
+
+ require.Error(t, cmd.Execute(nil))
+ require.True(t, fake.Called)
+}
+
+func TestExecuteGivenNonexistentCommand(t *testing.T) {
+ cmd := &Command{RootDir: "/tmp/does/not/exist", Args: fakeArgs}
+
+ require.Error(t, cmd.Execute(nil))
+}