diff options
| author | Mark de Wever <koraq@xs4all.nl> | 2022-09-04 13:56:36 +0200 |
|---|---|---|
| committer | Mark de Wever <koraq@xs4all.nl> | 2022-09-07 18:39:39 +0200 |
| commit | b490c8a6623c6a32cebf45567c467d38c3285fb9 (patch) | |
| tree | b40a111ac8ca2f2840e21e019682b27c2e55ac20 /libcxx/utils/generate_feature_test_macro_components.py | |
| parent | a4a29438f451370ed241dde30bfcaab0fdf2ab71 (diff) | |
| download | llvm-b490c8a6623c6a32cebf45567c467d38c3285fb9.tar.gz | |
[libc++][format] Updates feature-test macros.
During the discussion on the SG-10 mailinglist regarding the format
feature-test macros voted in during the last plenary it turns out libc++
can't mark the format feature-test macro as implemented.
According to
https://isocpp.org/std/standing-documents/sd-6-sg10-feature-test-recommendations#__cpp_lib_format
the not yet implemented paper
P1361R2 Integration of chrono with text formatting
affects the feature test macro.
Note that P1361R2 doesn't mention the feature-test macro nor is there an
LWG-issue to address the issue. The reporter of the issue didn't recall
where this requirement exactly has been decided.
Reviewed By: ldionne, #libc
Differential Revision: https://reviews.llvm.org/D133271
Diffstat (limited to 'libcxx/utils/generate_feature_test_macro_components.py')
| -rwxr-xr-x | libcxx/utils/generate_feature_test_macro_components.py | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/libcxx/utils/generate_feature_test_macro_components.py b/libcxx/utils/generate_feature_test_macro_components.py index 41e85980bc8f..37860a731d29 100755 --- a/libcxx/utils/generate_feature_test_macro_components.py +++ b/libcxx/utils/generate_feature_test_macro_components.py @@ -313,15 +313,17 @@ feature_test_macros = [ add_version_header(x) for x in [ "libcxx_guard": "!defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_filesystem)" }, { "name": "__cpp_lib_format", - # P2508, P2286, and P2419 were accepted in the same plenary and modify this - # feature-test macro. We expect to see an LWG issue soon. For now keep the - # value as is. - # TODO FMT Set P2508's feature-test macro. - #"values": { "c++20": 202106, "c++23": 202207" }, - "values": { "c++20": 202106 }, + "values": { + # "c++20": 201907 Not implemented P1361R2 Integration of chrono with text formatting + # "c++20": 202106 Fully implemented + # "c++20": 202110 Not implemented P2372R3 Fixing locale handling in chrono formatters + "c++20": 202106, + # "c++23": 202207, Not implemented P2419R2 Clarify handling of encodings in localized formatting of chrono types + }, "headers": ["format"], "test_suite_guard": "!defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)", "libcxx_guard": "!defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)", + "unimplemented": True, }, { "name": "__cpp_lib_forward_like", "values": { "c++2b": 202207 }, |