summaryrefslogtreecommitdiff
path: root/ironic_python_agent/api/controllers/v1/command.py
diff options
context:
space:
mode:
authorJim Rollenhagen <jim@jimrollenhagen.com>2014-09-10 15:24:12 -0700
committerJim Rollenhagen <jim@jimrollenhagen.com>2014-09-22 07:31:09 -0700
commita524db83b6337a2b745654b6dd28bb4abd027ac6 (patch)
treec3a434178f9b81246506840a71a7758470f6556d /ironic_python_agent/api/controllers/v1/command.py
parentcdd9839155076e9916b8b2c2903a711090599359 (diff)
downloadironic-python-agent-a524db83b6337a2b745654b6dd28bb4abd027ac6.tar.gz
Add docstrings for api/ tree
Does what it says. Partial-Bug 1367915 Change-Id: Id1a718d652f6d98e6acb1d667f42d9c3cc82aef5
Diffstat (limited to 'ironic_python_agent/api/controllers/v1/command.py')
-rw-r--r--ironic_python_agent/api/controllers/v1/command.py35
1 files changed, 34 insertions, 1 deletions
diff --git a/ironic_python_agent/api/controllers/v1/command.py b/ironic_python_agent/api/controllers/v1/command.py
index 26cc82ac..e4483e29 100644
--- a/ironic_python_agent/api/controllers/v1/command.py
+++ b/ironic_python_agent/api/controllers/v1/command.py
@@ -22,6 +22,8 @@ from ironic_python_agent.api.controllers.v1 import base
class CommandResult(base.APIBase):
+ """Object representing the result of a given command."""
+
id = types.text
command_name = types.text
command_params = types.DictType(types.text, base.json_type)
@@ -31,6 +33,13 @@ class CommandResult(base.APIBase):
@classmethod
def from_result(cls, result):
+ """Convert a BaseCommandResult object to a CommandResult object.
+
+ :param result: a :class:`ironic_python_agent.extensions.base.
+ BaseCommandResult` object.
+ :returns: a :class:`ironic_python_agent.api.controllers.v1.command.
+ CommandResult` object.
+ """
instance = cls()
for field in ('id', 'command_name', 'command_params', 'command_status',
'command_error', 'command_result'):
@@ -39,10 +48,18 @@ class CommandResult(base.APIBase):
class CommandResultList(base.APIBase):
+ """An object representing a list of CommandResult objects."""
commands = [CommandResult]
@classmethod
def from_results(cls, results):
+ """Convert a list of BaseCommandResult objects to a CommandResultList.
+
+ :param results: a list of :class:`ironic_python_agent.extensions.base.
+ BaseCommandResult` objects.
+ :returns: a :class:`ironic_python_agent.api.controllers.v1.command.
+ CommandResultList` object.
+ """
instance = cls()
instance.commands = [CommandResult.from_result(result)
for result in results]
@@ -50,7 +67,7 @@ class CommandResultList(base.APIBase):
class Command(base.APIBase):
- """A command representation."""
+ """A representation of a command."""
name = types.wsattr(types.text, mandatory=True)
params = types.wsattr(base.MultiType(dict), mandatory=True)
@@ -60,12 +77,20 @@ class CommandController(rest.RestController):
@wsme_pecan.wsexpose(CommandResultList)
def get_all(self):
+ """Get all command results."""
agent = pecan.request.agent
results = agent.list_command_results()
return CommandResultList.from_results(results)
@wsme_pecan.wsexpose(CommandResult, types.text, types.text)
def get_one(self, result_id, wait=None):
+ """Get a command result by ID.
+
+ :param result_id: the ID of the result to get.
+ :param wait: if 'true', block until the command completes.
+ :returns: a :class:`ironic_python_agent.api.controller.v1.command.
+ CommandResult` object.
+ """
agent = pecan.request.agent
result = agent.get_command_result(result_id)
@@ -76,6 +101,14 @@ class CommandController(rest.RestController):
@wsme_pecan.wsexpose(CommandResult, types.text, body=Command)
def post(self, wait=None, command=None):
+ """Post a command for the agent to run.
+
+ :param wait: if 'true', block until the command completes.
+ :param command: the command to execute. If None, an InvalidCommandError
+ will be returned.
+ :returns: a :class:`ironic_python_agent.api.controller.v1.command.
+ CommandResult` object.
+ """
# the POST body is always the last arg,
# so command must be a kwarg here
if command is None: