summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVasyl Saienko <vsaienko@mirantis.com>2017-05-04 10:48:11 +0300
committerDean Troyer <dtroyer@gmail.com>2017-05-04 09:44:42 -0500
commitc69304e3d365dc2c67fab298eba0b9097d3819da (patch)
tree6a340082b604c41c545128fcbcd55a5313be0ad9
parent07a4363e995716f9b898623d9e43746fd36b5172 (diff)
downloadpython-openstackclient-3.11.0.tar.gz
Do not always init compute_client when doint port list3.11.0
This patch ensures that compute client is initialized only when needed (--server arg is passed) to openstack port list command. Otherwise it leads to failures on installations without Nova. Change-Id: I102683461daa2f7d05dd9d7a3ec72de551c65ca9 Closes-Bug: #1688194
-rw-r--r--openstackclient/network/v2/port.py2
-rw-r--r--releasenotes/notes/bug-1688194-bb008b65267a1169.yaml6
2 files changed, 7 insertions, 1 deletions
diff --git a/openstackclient/network/v2/port.py b/openstackclient/network/v2/port.py
index 3a32916b..0ed2e44a 100644
--- a/openstackclient/network/v2/port.py
+++ b/openstackclient/network/v2/port.py
@@ -519,7 +519,6 @@ class ListPort(command.Lister):
def take_action(self, parsed_args):
network_client = self.app.client_manager.network
- compute_client = self.app.client_manager.compute
identity_client = self.app.client_manager.identity
columns = (
@@ -548,6 +547,7 @@ class ListPort(command.Lister):
ignore_missing=False)
filters['device_id'] = _router.id
if parsed_args.server:
+ compute_client = self.app.client_manager.compute
server = utils.find_resource(compute_client.servers,
parsed_args.server)
filters['device_id'] = server.id
diff --git a/releasenotes/notes/bug-1688194-bb008b65267a1169.yaml b/releasenotes/notes/bug-1688194-bb008b65267a1169.yaml
new file mode 100644
index 00000000..f7e6ad49
--- /dev/null
+++ b/releasenotes/notes/bug-1688194-bb008b65267a1169.yaml
@@ -0,0 +1,6 @@
+---
+fixes:
+ - |
+ Fix issue in ``port list`` command when no Compute endpoint is in the
+ Service Catalog.
+ [Bug `1688194 <https://bugs.launchpad.net/bugs/1688194>`_]