diff options
| author | Jenkins <jenkins@review.openstack.org> | 2014-06-27 21:41:33 +0000 |
|---|---|---|
| committer | Gerrit Code Review <review@openstack.org> | 2014-06-27 21:41:33 +0000 |
| commit | 58583b55cac8309c78d91e5d9f985f58ef0a1bdb (patch) | |
| tree | 1b8c9ebb3050a5fa5d8903810c45a48956ca0c93 | |
| parent | 63b1c060244bb08d59ef9df8e26d901e98bf3bf8 (diff) | |
| parent | 11f3654f6e29c8d66a0ef550963056b70bc100d3 (diff) | |
| download | python-openstackclient-58583b55cac8309c78d91e5d9f985f58ef0a1bdb.tar.gz | |
Merge "Fix PEP8 E265 errors"
| -rw-r--r-- | openstackclient/common/restapi.py | 10 | ||||
| -rw-r--r-- | openstackclient/compute/v2/server.py | 2 | ||||
| -rw-r--r-- | openstackclient/tests/common/test_restapi.py | 4 | ||||
| -rw-r--r-- | openstackclient/tests/identity/v3/fakes.py | 3 | ||||
| -rw-r--r-- | openstackclient/tests/volume/v1/test_volume.py | 2 | ||||
| -rw-r--r-- | tox.ini | 2 |
6 files changed, 4 insertions, 19 deletions
diff --git a/openstackclient/common/restapi.py b/openstackclient/common/restapi.py index 1bb64fae..f20ad23d 100644 --- a/openstackclient/common/restapi.py +++ b/openstackclient/common/restapi.py @@ -251,16 +251,6 @@ class RESTApi(object): else: return response.json() - ###hack this for keystone!!! - #data = body[response_key] - # NOTE(ja): keystone returns values as list as {'values': [ ... ]} - # unlike other services which just return the list... - #if isinstance(data, dict): - # try: - # data = data['values'] - # except KeyError: - # pass - def set(self, url, data=None, response_key=None, **kwargs): """Update an object via a PUT request diff --git a/openstackclient/compute/v2/server.py b/openstackclient/compute/v2/server.py index f75444f2..2dcc7ae9 100644 --- a/openstackclient/compute/v2/server.py +++ b/openstackclient/compute/v2/server.py @@ -693,7 +693,7 @@ class MigrateServer(command.Command): if utils.wait_for_status( compute_client.servers.get, server.id, - #callback=_show_progress, + callback=_show_progress, ): sys.stdout.write('Complete\n') else: diff --git a/openstackclient/tests/common/test_restapi.py b/openstackclient/tests/common/test_restapi.py index 291818c1..d4fe2d3d 100644 --- a/openstackclient/tests/common/test_restapi.py +++ b/openstackclient/tests/common/test_restapi.py @@ -137,10 +137,6 @@ class TestRESTApi(utils.TestCase): user_agent=fake_user_agent, ) gopher = api.request('GET', fake_url) - #session_mock.return_value.headers.setdefault.assert_called_with( - # 'X-Auth-Token', - # fake_auth, - #) session_mock.return_value.request.assert_called_with( 'GET', fake_url, diff --git a/openstackclient/tests/identity/v3/fakes.py b/openstackclient/tests/identity/v3/fakes.py index 711a423d..8143409d 100644 --- a/openstackclient/tests/identity/v3/fakes.py +++ b/openstackclient/tests/identity/v3/fakes.py @@ -114,7 +114,8 @@ IDENTITY_PROVIDER = { 'description': idp_description } -#Assignments +# Assignments + ASSIGNMENT_WITH_PROJECT_ID_AND_USER_ID = { 'scope': {'project': {'id': project_id}}, 'user': {'id': user_id}, diff --git a/openstackclient/tests/volume/v1/test_volume.py b/openstackclient/tests/volume/v1/test_volume.py index d881598a..cb006b10 100644 --- a/openstackclient/tests/volume/v1/test_volume.py +++ b/openstackclient/tests/volume/v1/test_volume.py @@ -220,7 +220,6 @@ class TestVolumeCreate(TestVolume): None, None, volume_fakes.volume_name, - #volume_fakes.volume_description, None, None, identity_fakes.user_id, @@ -296,7 +295,6 @@ class TestVolumeCreate(TestVolume): None, None, volume_fakes.volume_name, - #volume_fakes.volume_description, None, None, identity_fakes.user_id, @@ -28,6 +28,6 @@ commands= python setup.py build_sphinx [flake8] -ignore = E126,E202,W602,H302,H402,E265,H305,H307,H904 +ignore = E126,E202,W602,H302,H402,H305,H307,H904 show-source = True exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools |