diff options
| author | Dean Troyer <dtroyer@gmail.com> | 2014-05-08 10:58:17 -0500 |
|---|---|---|
| committer | Dean Troyer <dtroyer@gmail.com> | 2014-05-08 15:04:22 -0500 |
| commit | da5e31dbb629c26f54e476ca3587455c3a17cdcb (patch) | |
| tree | f902a0da2fefef6040577fb0fbd7f165c080bac1 | |
| parent | 6c5f2e39e23a11236986b119974b90bf15f73878 (diff) | |
| download | python-openstackclient-da5e31dbb629c26f54e476ca3587455c3a17cdcb.tar.gz | |
Fix server image create
The final find_resource() call errored because servers.create_image()
returns an image ID rather than an Image resource. Reset expectations
and arguments.
Change-Id: I1b9132f66091f9df76198724156acb7a6fb2f6fe
| -rw-r--r-- | openstackclient/compute/v2/server.py | 8 | ||||
| -rw-r--r-- | openstackclient/tests/compute/v2/test_server.py | 6 |
2 files changed, 5 insertions, 9 deletions
diff --git a/openstackclient/compute/v2/server.py b/openstackclient/compute/v2/server.py index 808741fd..9cff03d6 100644 --- a/openstackclient/compute/v2/server.py +++ b/openstackclient/compute/v2/server.py @@ -393,7 +393,7 @@ class CreateServerImage(show.ShowOne): parser = super(CreateServerImage, self).get_parser(prog_name) parser.add_argument( 'server', - metavar='<server', + metavar='<server>', help='Server (name or ID)', ) parser.add_argument( @@ -421,7 +421,7 @@ class CreateServerImage(show.ShowOne): else: name = server.name - image = compute_client.servers.create_image( + image_id = compute_client.servers.create_image( server, name, ) @@ -429,7 +429,7 @@ class CreateServerImage(show.ShowOne): if parsed_args.wait: if utils.wait_for_status( image_client.images.get, - image, + image_id, callback=_show_progress, ): sys.stdout.write('\n') @@ -443,7 +443,7 @@ class CreateServerImage(show.ShowOne): image = utils.find_resource( image_client.images, - image.id, + image_id, ) info = {} diff --git a/openstackclient/tests/compute/v2/test_server.py b/openstackclient/tests/compute/v2/test_server.py index 4cd294cc..efe4c58b 100644 --- a/openstackclient/tests/compute/v2/test_server.py +++ b/openstackclient/tests/compute/v2/test_server.py @@ -80,11 +80,7 @@ class TestServerImageCreate(TestServer): loaded=True, ) - self.servers_mock.create_image.return_value = fakes.FakeResource( - None, - copy.deepcopy(image_fakes.IMAGE), - loaded=True, - ) + self.servers_mock.create_image.return_value = image_fakes.image_id self.images_mock.get.return_value = fakes.FakeResource( None, |