diff options
| author | Carlos Konstanski <ckonstanski@pippiandcarlos.com> | 2017-12-01 14:58:52 -0700 |
|---|---|---|
| committer | Carlos Konstanski <ckonstanski@pippiandcarlos.com> | 2017-12-01 15:17:03 -0700 |
| commit | dab49df461d7ca68001632f11dc5bf1229271de9 (patch) | |
| tree | 7fdb51332f123caea4a24b0a778108c0998e085f | |
| parent | b061b9c34e2fa6ecf0922e056a0fbdad28fa0685 (diff) | |
| download | python-openstackclient-dab49df461d7ca68001632f11dc5bf1229271de9.tar.gz | |
openstack subnet create fails when tags is None
In network/v2/_tag.py lines 105 and 110: obj.tags can be None, in
which case set(obj.tags) throws a NoneType exception.
Change-Id: I1e965ec947844cbf84676fab27a2261fc0c0ea49
Closes-Bug: #1735836
| -rw-r--r-- | openstackclient/network/v2/_tag.py | 4 | ||||
| -rw-r--r-- | releasenotes/notes/bug-1735836-9be6d777a6e6410b.yaml | 6 |
2 files changed, 8 insertions, 2 deletions
diff --git a/openstackclient/network/v2/_tag.py b/openstackclient/network/v2/_tag.py index d1e59937..ce39f35e 100644 --- a/openstackclient/network/v2/_tag.py +++ b/openstackclient/network/v2/_tag.py @@ -102,10 +102,10 @@ def update_tags_for_set(client, obj, parsed_args): if parsed_args.no_tag: tags = set() else: - tags = set(obj.tags) + tags = set(obj.tags or []) if parsed_args.tags: tags |= set(parsed_args.tags) - if set(obj.tags) != tags: + if set(obj.tags or []) != tags: client.set_tags(obj, list(tags)) diff --git a/releasenotes/notes/bug-1735836-9be6d777a6e6410b.yaml b/releasenotes/notes/bug-1735836-9be6d777a6e6410b.yaml new file mode 100644 index 00000000..34604853 --- /dev/null +++ b/releasenotes/notes/bug-1735836-9be6d777a6e6410b.yaml @@ -0,0 +1,6 @@ +--- +fixes: + - | + ``openstack subnet create`` failed with a NoneType exception when + there were no tags. + [Bug `1735836 <https://bugs.launchpad.net/python-openstackclient/+bug/1735836>`_] |