summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJenkins <jenkins@review.openstack.org>2017-02-08 02:53:38 +0000
committerGerrit Code Review <review@openstack.org>2017-02-08 02:53:38 +0000
commite35c97a4fc323f9771908566656c172ba4bbd340 (patch)
tree043be872ade9302cc8d327136c6957927232f246
parent3afd2b7ff25af7e7998e9c8f4adac8a58a079675 (diff)
parente8b6a9f7be7e773396c8fe1021d8798aa0e2a4a9 (diff)
downloadpython-openstackclient-e35c97a4fc323f9771908566656c172ba4bbd340.tar.gz
Merge "Fix wrong behavior of parsing plugin service name"
-rw-r--r--openstackclient/shell.py4
-rw-r--r--releasenotes/notes/bug-1658614-f84a8cece6f2ef8c.yaml7
2 files changed, 10 insertions, 1 deletions
diff --git a/openstackclient/shell.py b/openstackclient/shell.py
index e08eee61..d7fe6ac1 100644
--- a/openstackclient/shell.py
+++ b/openstackclient/shell.py
@@ -76,7 +76,9 @@ class OpenStackShell(shell.OpenStackShell):
# Loop through extensions to get API versions
for mod in clientmanager.PLUGIN_MODULES:
default_version = getattr(mod, 'DEFAULT_API_VERSION', None)
- option = mod.API_VERSION_OPTION.replace('os_', '')
+ # Only replace the first instance of "os", some service names will
+ # have "os" in their name, like: "antiddos"
+ option = mod.API_VERSION_OPTION.replace('os_', '', 1)
version_opt = str(self.cloud.config.get(option, default_version))
if version_opt:
api = mod.API_NAME
diff --git a/releasenotes/notes/bug-1658614-f84a8cece6f2ef8c.yaml b/releasenotes/notes/bug-1658614-f84a8cece6f2ef8c.yaml
new file mode 100644
index 00000000..b69e384d
--- /dev/null
+++ b/releasenotes/notes/bug-1658614-f84a8cece6f2ef8c.yaml
@@ -0,0 +1,7 @@
+---
+fixes:
+ - |
+ Fix wrong behavior of parsing plugin service name when the service name end
+ with keyword ``os``, like: antiddos. That cause the service api version
+ specified by users don't work.
+ [Bug `1658614 <https://bugs.launchpad.net/python-openstackclient/+bug/1658614>`_]