summaryrefslogtreecommitdiff
path: root/openstackclient/common/utils.py
diff options
context:
space:
mode:
authorTerry Howe <terrylhowe@gmail.com>2014-05-22 17:38:41 -0600
committerTerry Howe <terrylhowe@gmail.com>2014-06-17 10:24:26 -0600
commit0b2987fef389603b95b2ba7b788492b8baa56745 (patch)
tree73e20c7711d383515bf0e675504d23b134c48758 /openstackclient/common/utils.py
parent6380b8b95918a42cee63c21b90f7d8d55854d0c8 (diff)
downloadpython-openstackclient-0b2987fef389603b95b2ba7b788492b8baa56745.tar.gz
Fix find_resource for keystone and cinder
The find_resource method had two hacks in in to support cinder and keystone and I have removed those in favor of a monkey patch for cinder. The find_resource method used to attempt to UUID parse the id, but it would do a manager.get anyway. I changed it to skip the UUID parsing. This will make things run minorly faster and it supports LDAP for keystone. The find_resource used to attempt to use display_name=name_or_id when finding. This was a hack for cinder support, but it breaks keystone because keystone totally messes up with the bogus filter and keystone refuses to fix it. Change-Id: I66e45a6341f704900f1d5321a0e70eac3d051665 Closes-Bug: #1306699
Diffstat (limited to 'openstackclient/common/utils.py')
-rw-r--r--openstackclient/common/utils.py13
1 files changed, 0 insertions, 13 deletions
diff --git a/openstackclient/common/utils.py b/openstackclient/common/utils.py
index bc9ed264..a420dd51 100644
--- a/openstackclient/common/utils.py
+++ b/openstackclient/common/utils.py
@@ -21,7 +21,6 @@ import os
import six
import sys
import time
-import uuid
from openstackclient.common import exceptions
from openstackclient.openstack.common import strutils
@@ -37,13 +36,6 @@ def find_resource(manager, name_or_id):
except exceptions.NotFound:
pass
- # Try to get entity as uuid
- try:
- uuid.UUID(str(name_or_id))
- return manager.get(name_or_id)
- except (ValueError, exceptions.NotFound):
- pass
-
# Try directly using the passed value
try:
return manager.get(name_or_id)
@@ -65,11 +57,6 @@ def find_resource(manager, name_or_id):
# Eventually this should be pulled from a common set
# of client exceptions.
except Exception as ex:
- try:
- return manager.find(display_name=name_or_id)
- except Exception:
- pass
-
if type(ex).__name__ == 'NotFound':
msg = "No %s with a name or ID of '%s' exists." % \
(manager.resource_class.__name__.lower(), name_or_id)