summaryrefslogtreecommitdiff
path: root/openstackclient/compute/v2
diff options
context:
space:
mode:
authorZuul <zuul@review.openstack.org>2018-10-26 03:20:17 +0000
committerGerrit Code Review <review@openstack.org>2018-10-26 03:20:17 +0000
commit0fa3c84b4fff273c75de454736cd0d631ee40a08 (patch)
tree5ad3504432ca7c9864de258c26fff49956875687 /openstackclient/compute/v2
parent02f492ae4cc52ed2642f42bc0c1e5e417ebfe527 (diff)
parent1008544882fbdae16b045abca05cf3e2e8a14787 (diff)
downloadpython-openstackclient-0fa3c84b4fff273c75de454736cd0d631ee40a08.tar.gz
Merge "Default --nic to 'auto' if creating a server with >= 2.37"
Diffstat (limited to 'openstackclient/compute/v2')
-rw-r--r--openstackclient/compute/v2/server.py11
1 files changed, 8 insertions, 3 deletions
diff --git a/openstackclient/compute/v2/server.py b/openstackclient/compute/v2/server.py
index 67b4140a..4f672428 100644
--- a/openstackclient/compute/v2/server.py
+++ b/openstackclient/compute/v2/server.py
@@ -809,9 +809,14 @@ class CreateServer(command.ShowOne):
raise exceptions.CommandError(msg)
nics = nics[0]
else:
- # Default to empty list if nothing was specified, let nova side to
- # decide the default behavior.
- nics = []
+ # Compute API version >= 2.37 requires a value, so default to
+ # 'auto' to maintain legacy behavior if a nic wasn't specified.
+ if compute_client.api_version >= api_versions.APIVersion('2.37'):
+ nics = 'auto'
+ else:
+ # Default to empty list if nothing was specified, let nova
+ # side to decide the default behavior.
+ nics = []
# Check security group exist and convert ID to name
security_group_names = []