diff options
| author | Dr. Jens Harbott <harbott@osism.tech> | 2022-12-06 23:44:46 +0100 |
|---|---|---|
| committer | Brian Haley <haleyb.dev@gmail.com> | 2022-12-12 12:27:48 -0500 |
| commit | f23322c5ef59704462330e882dc97694c1d9a7c1 (patch) | |
| tree | 6f58ee155580b24d545895fdef0ffb9ce96c9bd1 /openstackclient/compute | |
| parent | 29129a7715feb750b7738a5884f9d2f49491a511 (diff) | |
| download | python-openstackclient-f23322c5ef59704462330e882dc97694c1d9a7c1.tar.gz | |
Fix parameter handling in server add fixed ip cmd
The fixed_ip_address parameter needs to be passed in a hash with key
"ip_address" in order to be processed by the server, the previous arg
was simply being ignored.
Added a functional test for better coverage.
Closes-Bug: 1998927
Change-Id: I6956d2642d8e80fc10c3739f0a571aa7ba276b1a
Diffstat (limited to 'openstackclient/compute')
| -rw-r--r-- | openstackclient/compute/v2/server.py | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/openstackclient/compute/v2/server.py b/openstackclient/compute/v2/server.py index 7afacb3e..098df4d1 100644 --- a/openstackclient/compute/v2/server.py +++ b/openstackclient/compute/v2/server.py @@ -290,9 +290,11 @@ class AddFixedIP(command.ShowOne): return ((), ()) kwargs = { - 'net_id': net_id, - 'fixed_ip': parsed_args.fixed_ip_address, + 'net_id': net_id } + if parsed_args.fixed_ip_address: + kwargs['fixed_ips'] = [ + {"ip_address": parsed_args.fixed_ip_address}] if parsed_args.tag: kwargs['tag'] = parsed_args.tag @@ -451,8 +453,7 @@ class AddPort(command.Command): port_id = parsed_args.port kwargs = { - 'port_id': port_id, - 'fixed_ip': None, + 'port_id': port_id } if parsed_args.tag: @@ -506,8 +507,7 @@ class AddNetwork(command.Command): net_id = parsed_args.network kwargs = { - 'net_id': net_id, - 'fixed_ip': None, + 'net_id': net_id } if parsed_args.tag: |