log take_action parameters in a single place

Previously each command logs take_action parameters explicitly
by using @utils.log_method decorator or log.debug().
Some commands have no logging.

This commit calls a logger in the base class and
drops all logging definition from individual commands.

Closes-Bug: #1532294
Change-Id: I43cd0290a4353c68c075bade9571c940733da1be

1 files changed, 4 insertions, 23 deletions

diff --git a/openstackclient/identity/v3/identity_provider.py b/openstackclient/identity/v3/identity_provider.py
index 4e086b68..0ff8acb9 100644
--- a/openstackclient/identity/v3/identity_provider.py
+++ b/openstackclient/identity/v3/identity_provider.py
@@ -13,21 +13,15 @@
 
 """Identity v3 IdentityProvider action implementations"""
 
-import logging
 import six
 
-from cliff import command
-from cliff import lister
-from cliff import show
-
+from openstackclient.common import command
 from openstackclient.common import utils
 
 
-class CreateIdentityProvider(show.ShowOne):
+class CreateIdentityProvider(command.ShowOne):
     """Create new identity provider"""
 
-    log = logging.getLogger(__name__ + '.CreateIdentityProvider')
-
     def get_parser(self, prog_name):
         parser = super(CreateIdentityProvider, self).get_parser(prog_name)
         parser.add_argument(
@@ -70,7 +64,6 @@ class CreateIdentityProvider(show.ShowOne):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
         if parsed_args.remote_id_file:
@@ -96,8 +89,6 @@ class CreateIdentityProvider(show.ShowOne):
 class DeleteIdentityProvider(command.Command):
     """Delete identity provider"""
 
-    log = logging.getLogger(__name__ + '.DeleteIdentityProvider')
-
     def get_parser(self, prog_name):
         parser = super(DeleteIdentityProvider, self).get_parser(prog_name)
         parser.add_argument(
@@ -107,7 +98,6 @@ class DeleteIdentityProvider(command.Command):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
         identity_client.federation.identity_providers.delete(
@@ -115,12 +105,9 @@ class DeleteIdentityProvider(command.Command):
         return
 
 
-class ListIdentityProvider(lister.Lister):
+class ListIdentityProvider(command.Lister):
     """List identity providers"""
 
-    log = logging.getLogger(__name__ + '.ListIdentityProvider')
-
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         columns = ('ID', 'Enabled', 'Description')
         identity_client = self.app.client_manager.identity
@@ -135,8 +122,6 @@ class ListIdentityProvider(lister.Lister):
 class SetIdentityProvider(command.Command):
     """Set identity provider properties"""
 
-    log = logging.getLogger(__name__ + '.SetIdentityProvider')
-
     def get_parser(self, prog_name):
         parser = super(SetIdentityProvider, self).get_parser(prog_name)
         parser.add_argument(
@@ -176,7 +161,6 @@ class SetIdentityProvider(command.Command):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         federation_client = self.app.client_manager.identity.federation
 
@@ -215,11 +199,9 @@ class SetIdentityProvider(command.Command):
         return zip(*sorted(six.iteritems(identity_provider._info)))
 
 
-class ShowIdentityProvider(show.ShowOne):
+class ShowIdentityProvider(command.ShowOne):
     """Display identity provider details"""
 
-    log = logging.getLogger(__name__ + '.ShowIdentityProvider')
-
     def get_parser(self, prog_name):
         parser = super(ShowIdentityProvider, self).get_parser(prog_name)
         parser.add_argument(
@@ -229,7 +211,6 @@ class ShowIdentityProvider(show.ShowOne):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
         idp = utils.find_resource(