log take_action parameters in a single place

Previously each command logs take_action parameters explicitly
by using @utils.log_method decorator or log.debug().
Some commands have no logging.

This commit calls a logger in the base class and
drops all logging definition from individual commands.

Closes-Bug: #1532294
Change-Id: I43cd0290a4353c68c075bade9571c940733da1be

1 files changed, 4 insertions, 23 deletions

diff --git a/openstackclient/identity/v3/service.py b/openstackclient/identity/v3/service.py
index 85081aa7..42117c8d 100644
--- a/openstackclient/identity/v3/service.py
+++ b/openstackclient/identity/v3/service.py
@@ -15,22 +15,16 @@
 
 """Identity v3 Service action implementations"""
 
-import logging
 import six
 
-from cliff import command
-from cliff import lister
-from cliff import show
-
+from openstackclient.common import command
 from openstackclient.common import utils
 from openstackclient.identity import common
 
 
-class CreateService(show.ShowOne):
+class CreateService(command.ShowOne):
     """Create new service"""
 
-    log = logging.getLogger(__name__ + '.CreateService')
-
     def get_parser(self, prog_name):
         parser = super(CreateService, self).get_parser(prog_name)
         parser.add_argument(
@@ -61,7 +55,6 @@ class CreateService(show.ShowOne):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
 
@@ -83,8 +76,6 @@ class CreateService(show.ShowOne):
 class DeleteService(command.Command):
     """Delete service"""
 
-    log = logging.getLogger(__name__ + '.DeleteService')
-
     def get_parser(self, prog_name):
         parser = super(DeleteService, self).get_parser(prog_name)
         parser.add_argument(
@@ -94,7 +85,6 @@ class DeleteService(command.Command):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
 
@@ -104,11 +94,9 @@ class DeleteService(command.Command):
         return
 
 
-class ListService(lister.Lister):
+class ListService(command.Lister):
     """List services"""
 
-    log = logging.getLogger(__name__ + '.ListService')
-
     def get_parser(self, prog_name):
         parser = super(ListService, self).get_parser(prog_name)
         parser.add_argument(
@@ -119,7 +107,6 @@ class ListService(lister.Lister):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
 
         if parsed_args.long:
@@ -136,8 +123,6 @@ class ListService(lister.Lister):
 class SetService(command.Command):
     """Set service properties"""
 
-    log = logging.getLogger(__name__ + '.SetService')
-
     def get_parser(self, prog_name):
         parser = super(SetService, self).get_parser(prog_name)
         parser.add_argument(
@@ -173,7 +158,6 @@ class SetService(command.Command):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
 
@@ -205,11 +189,9 @@ class SetService(command.Command):
         return
 
 
-class ShowService(show.ShowOne):
+class ShowService(command.ShowOne):
     """Display service details"""
 
-    log = logging.getLogger(__name__ + '.ShowService')
-
     def get_parser(self, prog_name):
         parser = super(ShowService, self).get_parser(prog_name)
         parser.add_argument(
@@ -219,7 +201,6 @@ class ShowService(show.ShowOne):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity