diff options
| author | gvrangan <venkatrangang@hcl.com> | 2017-09-21 06:37:10 +0530 |
|---|---|---|
| committer | Dean Troyer <dtroyer@gmail.com> | 2017-09-26 21:00:14 +0000 |
| commit | 221b7052abcefa56213a6516cecc6de9c73026d1 (patch) | |
| tree | 49250ce01b86991a1a41b818a4d857d40b2f5ab0 /openstackclient/network | |
| parent | f88d2f53ba576734a81227410e0232616dc766f4 (diff) | |
| download | python-openstackclient-221b7052abcefa56213a6516cecc6de9c73026d1.tar.gz | |
Support icmp-type and icmp-code to be set as zero
When icmp-type or icmp-code are set to 0, the current implementation
ignores the value, this fix will allow the value to be copied and
displayed
Change-Id: I96133a57883d22e98fcbb9fe0328d9e050472469
Signed-off-by: gvrangan <venkatrangang@hcl.com>
Diffstat (limited to 'openstackclient/network')
| -rw-r--r-- | openstackclient/network/v2/security_group_rule.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/openstackclient/network/v2/security_group_rule.py b/openstackclient/network/v2/security_group_rule.py index ad685cf8..06d46725 100644 --- a/openstackclient/network/v2/security_group_rule.py +++ b/openstackclient/network/v2/security_group_rule.py @@ -294,9 +294,9 @@ class CreateSecurityGroupRule(common.NetworkAndComputeShowOne): if parsed_args.dst_port and not is_icmp_protocol: attrs['port_range_min'] = parsed_args.dst_port[0] attrs['port_range_max'] = parsed_args.dst_port[1] - if parsed_args.icmp_type: + if parsed_args.icmp_type is not None and parsed_args.icmp_type >= 0: attrs['port_range_min'] = parsed_args.icmp_type - if parsed_args.icmp_code: + if parsed_args.icmp_code is not None and parsed_args.icmp_code >= 0: attrs['port_range_max'] = parsed_args.icmp_code # NOTE(dtroyer): --src-ip and --src-group were deprecated in Nov 2016. |