diff options
| author | Kailun Qin <kailun.qin@intel.com> | 2019-03-13 02:43:59 +0800 |
|---|---|---|
| committer | Kailun Qin <kailun.qin@intel.com> | 2019-03-14 01:05:21 +0800 |
| commit | 510e9a7b8e567ce644473cad9e10651ff4bf2ca1 (patch) | |
| tree | a9c7bceacdc474ac06bdc86079aa46845e8bd2a6 /openstackclient/network | |
| parent | 28c06d06885b3ae93da07eb14411d92c3df7e792 (diff) | |
| download | python-openstackclient-510e9a7b8e567ce644473cad9e10651ff4bf2ca1.tar.gz | |
Fix: incorrect check when no shared/private input
When neither of "--shared" and "--private" is input, we should not allow
to specify "--project". Defaulting the created network segment range to
shared is expected. Therefore, "project_id" attr should only be
populated on a private range creation.
Change-Id: Iab345e1651dd8b7904ff64a20633f194d719bb84
Story: 2005206
Task: 29980
Diffstat (limited to 'openstackclient/network')
| -rw-r--r-- | openstackclient/network/v2/network_segment_range.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/openstackclient/network/v2/network_segment_range.py b/openstackclient/network/v2/network_segment_range.py index 75820bc5..567b5b6e 100644 --- a/openstackclient/network/v2/network_segment_range.py +++ b/openstackclient/network/v2/network_segment_range.py @@ -168,7 +168,7 @@ class CreateNetworkSegmentRange(command.ShowOne): identity_client = self.app.client_manager.identity - if parsed_args.shared and parsed_args.project: + if not parsed_args.private and parsed_args.project: msg = _("--project is only allowed with --private") raise exceptions.CommandError(msg) @@ -202,7 +202,7 @@ class CreateNetworkSegmentRange(command.ShowOne): msg = (_("Failed to create the network segment range for " "project %(project_id)s") % parsed_args.project_id) raise exceptions.CommandError(msg) - elif not parsed_args.shared: + elif not attrs['shared']: # default to the current project if no project specified and shared # is not specified. # Get the project id from the current auth. |
