summaryrefslogtreecommitdiff
path: root/openstackclient/network
diff options
context:
space:
mode:
authorHuanxuan Ao <huanxuan.ao@easystack.cn>2016-10-20 10:55:50 +0800
committerHuanxuan Ao <huanxuan.ao@easystack.cn>2016-10-20 12:37:40 +0800
commit57d5f945402681e5f7d62b9ca99fc229927cc784 (patch)
treecb7a782c6b5e1925dc86bec7e11d22684fb01b84 /openstackclient/network
parentfee1a31296cb47de105d0fa70a509570151f9d81 (diff)
downloadpython-openstackclient-57d5f945402681e5f7d62b9ca99fc229927cc784.tar.gz
Allow input the QoS policy name in network rbac create command
We could input a QoS policy ID for the "rbac_object" parameter in "network rbac create" command but not name before. After this change, "rbac_object" parameter can be both QoS policy name or ID. Change-Id: I0fd6b5b5ae410074d85475ef49e5a0a9a52bf86f
Diffstat (limited to 'openstackclient/network')
-rw-r--r--openstackclient/network/v2/network_rbac.py9
1 files changed, 4 insertions, 5 deletions
diff --git a/openstackclient/network/v2/network_rbac.py b/openstackclient/network/v2/network_rbac.py
index bb29579f..b1e0413f 100644
--- a/openstackclient/network/v2/network_rbac.py
+++ b/openstackclient/network/v2/network_rbac.py
@@ -47,9 +47,9 @@ def _get_attrs(client_manager, parsed_args):
object_id = network_client.find_network(
parsed_args.rbac_object, ignore_missing=False).id
if parsed_args.type == 'qos_policy':
- # TODO(Huanxuan Ao): Support finding a object ID by obejct name
- # after qos policy finding supported in SDK.
- object_id = parsed_args.rbac_object
+ object_id = network_client.find_qos_policy(
+ parsed_args.rbac_object,
+ ignore_missing=False).id
attrs['object_id'] = object_id
identity_client = client_manager.identity
@@ -78,8 +78,7 @@ class CreateNetworkRBAC(command.ShowOne):
parser.add_argument(
'rbac_object',
metavar="<rbac-object>",
- help=_("The object to which this RBAC policy affects (name or "
- "ID for network objects, ID only for QoS policy objects)")
+ help=_("The object to which this RBAC policy affects (name or ID)")
)
parser.add_argument(
'--type',