summaryrefslogtreecommitdiff
path: root/openstackclient/network
diff options
context:
space:
mode:
authorColleen Murphy <comurphy@suse.com>2017-03-14 01:24:31 +0100
committerColleen Murphy <comurphy@suse.com>2017-03-14 09:23:19 +0100
commit853ea5ab59e5d7845d389e46527038575c3c170c (patch)
tree2be78acf1908ce25a40ed14bea06fb0adbdf12e1 /openstackclient/network
parent4a19f6753b9e21b3089824d17943b39c211a616a (diff)
downloadpython-openstackclient-853ea5ab59e5d7845d389e46527038575c3c170c.tar.gz
Narrow expected responses for CheckUserInGroup
When checking whether a given user is in a given group, keystone will return a 404 Not Found if all went well but the user was not in the group. It may also return a 403 if the user and the group are in different backends, which would also mean that the user was not in the group[1]. Any other 400 response is a client error and any 500 response is a server error to which the user should be alerted. Without this patch, openstackclient treats any exception as a valid "not found" and may end up hiding server errors. This patch reduces the caught exceptions to 403 and 404 responses and treats everything else as an error. [1] https://developer.openstack.org/api-ref/identity/v3/?expanded=check-whether-user-belongs-to-group-detail#check-whether-user-belongs-to-group Closes-bug: #1672634 Change-Id: Id3f3b2409b7cee480ee3c19b6d6c3070599ffe8f
Diffstat (limited to 'openstackclient/network')
0 files changed, 0 insertions, 0 deletions