diff options
| author | Tang Chen <chen.tang@easystack.cn> | 2016-02-27 15:38:04 +0800 |
|---|---|---|
| committer | Tang Chen <chen.tang@easystack.cn> | 2016-02-27 15:38:04 +0800 |
| commit | 058232b9998b760d508bf1e8746e429ad45e4e8d (patch) | |
| tree | 0d8de3e80e56b72c067f7e12f1427ca455d02ced /openstackclient/tests/compute/v2/test_service.py | |
| parent | 2819450be5d4fa57c6efdb4cd225f59bab894fba (diff) | |
| download | python-openstackclient-058232b9998b760d508bf1e8746e429ad45e4e8d.tar.gz | |
[Compute] Check return value is None in compute unit tests.
take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of
these commands.
Change-Id: I953480ecff3b5beb12255d866d0e1df45f130efd
Partial-Bug: #1550636
Diffstat (limited to 'openstackclient/tests/compute/v2/test_service.py')
| -rw-r--r-- | openstackclient/tests/compute/v2/test_service.py | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/openstackclient/tests/compute/v2/test_service.py b/openstackclient/tests/compute/v2/test_service.py index 54adaab3..2f8b2e7d 100644 --- a/openstackclient/tests/compute/v2/test_service.py +++ b/openstackclient/tests/compute/v2/test_service.py @@ -49,11 +49,12 @@ class TestServiceDelete(TestService): ] parsed_args = self.check_parser(self.cmd, arglist, verifylist) - self.cmd.take_action(parsed_args) + result = self.cmd.take_action(parsed_args) self.service_mock.delete.assert_called_with( compute_fakes.service_binary, ) + self.assertIsNone(result) class TestServiceList(TestService): @@ -124,12 +125,13 @@ class TestServiceSet(TestService): ] parsed_args = self.check_parser(self.cmd, arglist, verifylist) - self.cmd.take_action(parsed_args) + result = self.cmd.take_action(parsed_args) self.service_mock.enable.assert_called_with( compute_fakes.service_host, compute_fakes.service_binary, ) + self.assertIsNone(result) def test_service_set_disable(self): arglist = [ @@ -144,9 +146,10 @@ class TestServiceSet(TestService): ] parsed_args = self.check_parser(self.cmd, arglist, verifylist) - self.cmd.take_action(parsed_args) + result = self.cmd.take_action(parsed_args) self.service_mock.disable.assert_called_with( compute_fakes.service_host, compute_fakes.service_binary, ) + self.assertIsNone(result) |