Fix "module list --all" failed

KeyError cause the command "module list --all" failed,
fix it, and do refactor to filter private modules and
reduce the loop times, add related unit tests and
functional tests.

Change-Id: Icd77739502e05b5f763a04a92547497bf82d5d63
Closes-Bug: #1661814

1 files changed, 40 insertions, 0 deletions

diff --git a/openstackclient/tests/functional/common/test_module.py b/openstackclient/tests/functional/common/test_module.py
new file mode 100644
index 00000000..f56c1627
--- /dev/null
+++ b/openstackclient/tests/functional/common/test_module.py
@@ -0,0 +1,40 @@
+#   Copyright 2017 Huawei, Inc. All rights reserved.
+#
+#   Licensed under the Apache License, Version 2.0 (the "License"); you may
+#   not use this file except in compliance with the License. You may obtain
+#   a copy of the License at
+#
+#        http://www.apache.org/licenses/LICENSE-2.0
+#
+#   Unless required by applicable law or agreed to in writing, software
+#   distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+#   WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+#   License for the specific language governing permissions and limitations
+#   under the License.
+#
+
+import json
+
+from openstackclient.tests.functional import base
+
+
+class ModuleTest(base.TestCase):
+    """Functional tests for openstackclient module list output."""
+
+    CLIENTS = ['openstackclient',
+               'keystoneclient',
+               'novaclient']
+
+    LIBS = ['osc_lib',
+            'os_client_config',
+            'keystoneauth1']
+
+    def test_module_list_no_options(self):
+        json_output = json.loads(self.openstack('module list -f json'))
+        for one_module in self.CLIENTS:
+            self.assertIn(one_module, json_output.keys())
+
+    def test_module_list_with_all_option(self):
+        json_output = json.loads(self.openstack('module list --all -f json'))
+        for one_module in (self.CLIENTS + self.LIBS):
+            self.assertIn(one_module, json_output.keys())