summaryrefslogtreecommitdiff
path: root/openstackclient/tests/functional/network
diff options
context:
space:
mode:
authorNir Magnezi <nmagnezi@redhat.com>2017-01-09 12:31:47 +0200
committerNir Magnezi <nmagnezi@redhat.com>2017-01-09 16:44:08 +0200
commit142c5faae38c0619d218e0113644d6fa7bea76a8 (patch)
tree92c5eca5596bc497bb4a4152de8c60184cbb2905 /openstackclient/tests/functional/network
parent1957690754961aed8bf9c7894e3ab140a9f2c0b9 (diff)
downloadpython-openstackclient-142c5faae38c0619d218e0113644d6fa7bea76a8.tar.gz
Fix Octavia gate breakage caused by _get_columns()
The above mentioned function tries to extract keys() from an item which is type class. This patch fixes the issue by converting item to dict by using to_dict(). Change-Id: Ida520ae9fe64171d105f486ba06eda127a24547b Closes-Bug: #1654887
Diffstat (limited to 'openstackclient/tests/functional/network')
-rw-r--r--openstackclient/tests/functional/network/v2/test_security_group.py3
-rw-r--r--openstackclient/tests/functional/network/v2/test_security_group_rule.py2
2 files changed, 1 insertions, 4 deletions
diff --git a/openstackclient/tests/functional/network/v2/test_security_group.py b/openstackclient/tests/functional/network/v2/test_security_group.py
index 73f6deb3..debd81df 100644
--- a/openstackclient/tests/functional/network/v2/test_security_group.py
+++ b/openstackclient/tests/functional/network/v2/test_security_group.py
@@ -12,8 +12,6 @@
import uuid
-import testtools
-
from openstackclient.tests.functional import base
@@ -25,7 +23,6 @@ class SecurityGroupTests(base.TestCase):
FIELDS = ['name']
@classmethod
- @testtools.skip('broken SDK testing')
def setUpClass(cls):
opts = cls.get_opts(cls.FIELDS)
raw_output = cls.openstack('security group create ' + cls.NAME + opts)
diff --git a/openstackclient/tests/functional/network/v2/test_security_group_rule.py b/openstackclient/tests/functional/network/v2/test_security_group_rule.py
index 5d2e5843..ec3731eb 100644
--- a/openstackclient/tests/functional/network/v2/test_security_group_rule.py
+++ b/openstackclient/tests/functional/network/v2/test_security_group_rule.py
@@ -26,7 +26,6 @@ class SecurityGroupRuleTests(base.TestCase):
ID_HEADER = ['ID']
@classmethod
- @testtools.skip('broken SDK testing')
def setUpClass(cls):
# Create the security group to hold the rule.
opts = cls.get_opts(cls.NAME_FIELD)
@@ -55,6 +54,7 @@ class SecurityGroupRuleTests(base.TestCase):
cls.SECURITY_GROUP_NAME)
cls.assertOutput('', raw_output)
+ @testtools.skip('broken SDK testing')
def test_security_group_rule_list(self):
opts = self.get_opts(self.ID_HEADER)
raw_output = self.openstack('security group rule list ' +