diff options
| author | Tang Chen <chen.tang@easystack.cn> | 2016-03-05 17:12:42 +0800 |
|---|---|---|
| committer | Tang Chen <chen.tang@easystack.cn> | 2016-03-05 17:12:42 +0800 |
| commit | eb1574281b84e86ee4c4b65d900e1de82c24471e (patch) | |
| tree | 7a63847be854e6c89a078fae51eefe52accf5e23 /openstackclient/tests/identity/v3/test_user.py | |
| parent | fa3a34322c532c6ae09b7b21c305b6a92d99300a (diff) | |
| download | python-openstackclient-eb1574281b84e86ee4c4b65d900e1de82c24471e.tar.gz | |
Test take_action() instead of run() in unit tests
Some of the unit tests test run(), but not take_action().
For example, in openstackclient/tests/volume/v1/test_volume.py, there is:
def test_volume_set_size_smaller(self):
......
result = self.cmd.run(parsed_args)
self.assertEqual(0, result)
......
run() is defined in class Command in cliff. We don't need to test it in OSC
unit tests. On the contrary, we should test take_action(), which is
overwritten in each command classes in OSC.
Change-Id: If07e89953d40ac530f08cbb1ec05f5805171364b
Closes-bug: #1553468
Diffstat (limited to 'openstackclient/tests/identity/v3/test_user.py')
| -rw-r--r-- | openstackclient/tests/identity/v3/test_user.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/openstackclient/tests/identity/v3/test_user.py b/openstackclient/tests/identity/v3/test_user.py index 3757c5f8..571e2d79 100644 --- a/openstackclient/tests/identity/v3/test_user.py +++ b/openstackclient/tests/identity/v3/test_user.py @@ -754,8 +754,9 @@ class TestUserSet(TestUser): ] parsed_args = self.check_parser(self.cmd, arglist, verifylist) - result = self.cmd.run(parsed_args) - self.assertEqual(0, result) + result = self.cmd.take_action(parsed_args) + + self.assertIsNone(result) def test_user_set_name(self): arglist = [ |