diff options
| author | Tang Chen <tangchen@cn.fujitsu.com> | 2015-12-05 10:31:54 +0800 |
|---|---|---|
| committer | Tang Chen <tangchen@cn.fujitsu.com> | 2015-12-09 09:29:39 +0800 |
| commit | 511e8622944bc64822af07b1bd11681b0c5d45b3 (patch) | |
| tree | 449b89c40bc4b6d7f91d8aed392114d3315ae15d /openstackclient/tests/network | |
| parent | 0b4fb0bb662d71a85aba251e13d403cf692d8d54 (diff) | |
| download | python-openstackclient-511e8622944bc64822af07b1bd11681b0c5d45b3.tar.gz | |
Migrate "network delete" command to use SDK.
This patch makes "network delete" command use sdk.
Since we have to keep the other commands runnable with
the old network client, we use a temporary method to
create sdk network client. And as a result, the tests
need to patch a method to fake the temporary method,
which will be removed at last.
Change-Id: I1f2c404e4b0ff6727e4c535ce543aa406f2290ce
Implements: blueprint neutron-client
Co-Authored-By: Terry Howe <terrylhowe@gmail.com>
Co-Authored-By: Tang Chen <tangchen@cn.fujitsu.com>
Diffstat (limited to 'openstackclient/tests/network')
| -rw-r--r-- | openstackclient/tests/network/v2/test_network.py | 22 |
1 files changed, 12 insertions, 10 deletions
diff --git a/openstackclient/tests/network/v2/test_network.py b/openstackclient/tests/network/v2/test_network.py index 8648a11f..41be5933 100644 --- a/openstackclient/tests/network/v2/test_network.py +++ b/openstackclient/tests/network/v2/test_network.py @@ -314,34 +314,36 @@ class TestCreateNetworkIdentityV2(TestNetwork): ) +@mock.patch('openstackclient.network.v2.network._make_client_sdk') class TestDeleteNetwork(TestNetwork): + # The network to delete. + _network = network_fakes.FakeNetwork.create_one_network() + def setUp(self): super(TestDeleteNetwork, self).setUp() - self.network.delete_network = mock.Mock( - return_value=None - ) + self.network.delete_network = mock.Mock(return_value=None) - self.network.list_networks = mock.Mock( - return_value={RESOURCES: [copy.deepcopy(RECORD)]} - ) + self.network.find_network = mock.Mock(return_value=self._network) # Get the command object to test self.cmd = network.DeleteNetwork(self.app, self.namespace) - def test_delete(self): + def test_delete(self, _make_client_sdk): + _make_client_sdk.return_value = self.app.client_manager.network + arglist = [ - FAKE_NAME, + self._network.name, ] verifylist = [ - ('networks', [FAKE_NAME]), + ('networks', [self._network.name]), ] parsed_args = self.check_parser(self.cmd, arglist, verifylist) result = self.cmd.take_action(parsed_args) - self.network.delete_network.assert_called_with(FAKE_ID) + self.network.delete_network.assert_called_with(self._network) self.assertEqual(None, result) |
