[Subnet pool] Add 'subnet pool set' command support

This patch supports setting a new name, pool prefix,
default prefix length, minimum prefix length,
and maximum prefix length for a subnet pool.

Change-Id: I65bd71e0f54f2f65acefbc542df67a1b1ec26397
Partial-Bug: #1544591
Related-to: blueprint neutron-client

1 files changed, 93 insertions, 2 deletions

diff --git a/openstackclient/tests/network/v2/test_subnet_pool.py b/openstackclient/tests/network/v2/test_subnet_pool.py
index c4e3340d..9c372ac0 100644
--- a/openstackclient/tests/network/v2/test_subnet_pool.py
+++ b/openstackclient/tests/network/v2/test_subnet_pool.py
@@ -11,8 +11,10 @@
 #   under the License.
 #
 
+import argparse
 import mock
 
+from openstackclient.common import exceptions
 from openstackclient.common import utils
 from openstackclient.network.v2 import subnet_pool
 from openstackclient.tests.network.v2 import fakes as network_fakes
@@ -129,6 +131,96 @@ class TestListSubnetPool(TestSubnetPool):
         self.assertEqual(self.data_long, list(data))
 
 
+class TestSetSubnetPool(TestSubnetPool):
+
+    # The subnet_pool to set.
+    _subnet_pool = network_fakes.FakeSubnetPool.create_one_subnet_pool()
+
+    def setUp(self):
+        super(TestSetSubnetPool, self).setUp()
+
+        self.network.update_subnet_pool = mock.Mock(return_value=None)
+
+        self.network.find_subnet_pool = mock.Mock(
+            return_value=self._subnet_pool)
+
+        # Get the command object to test
+        self.cmd = subnet_pool.SetSubnetPool(self.app, self.namespace)
+
+    def test_set_this(self):
+        arglist = [
+            self._subnet_pool.name,
+            '--name', 'noob',
+            '--default-prefix-length', '8',
+            '--min-prefix-length', '8',
+        ]
+        verifylist = [
+            ('subnet_pool', self._subnet_pool.name),
+            ('name', 'noob'),
+            ('default_prefix_length', '8'),
+            ('min_prefix_length', '8'),
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        result = self.cmd.take_action(parsed_args)
+
+        attrs = {
+            'name': 'noob',
+            'default_prefix_length': '8',
+            'min_prefix_length': '8',
+        }
+        self.network.update_subnet_pool.assert_called_with(
+            self._subnet_pool, **attrs)
+        self.assertIsNone(result)
+
+    def test_set_that(self):
+        arglist = [
+            self._subnet_pool.name,
+            '--pool-prefix', '10.0.1.0/24',
+            '--pool-prefix', '10.0.2.0/24',
+            '--max-prefix-length', '16',
+        ]
+        verifylist = [
+            ('subnet_pool', self._subnet_pool.name),
+            ('prefixes', ['10.0.1.0/24', '10.0.2.0/24']),
+            ('max_prefix_length', '16'),
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        result = self.cmd.take_action(parsed_args)
+
+        prefixes = ['10.0.1.0/24', '10.0.2.0/24']
+        prefixes.extend(self._subnet_pool.prefixes)
+        attrs = {
+            'prefixes': prefixes,
+            'max_prefix_length': '16',
+        }
+        self.network.update_subnet_pool.assert_called_with(
+            self._subnet_pool, **attrs)
+        self.assertIsNone(result)
+
+    def test_set_nothing(self):
+        arglist = [self._subnet_pool.name, ]
+        verifylist = [('subnet_pool', self._subnet_pool.name), ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        self.assertRaises(exceptions.CommandError, self.cmd.take_action,
+                          parsed_args)
+
+    def test_set_len_negative(self):
+        arglist = [
+            self._subnet_pool.name,
+            '--max-prefix-length', '-16',
+        ]
+        verifylist = [
+            ('subnet_pool', self._subnet_pool.name),
+            ('max_prefix_length', '-16'),
+        ]
+
+        self.assertRaises(argparse.ArgumentTypeError, self.check_parser,
+                          self.cmd, arglist, verifylist)
+
+
 class TestShowSubnetPool(TestSubnetPool):
 
     # The subnet_pool to set.
@@ -189,14 +281,13 @@ class TestShowSubnetPool(TestSubnetPool):
         verifylist = [
             ('subnet_pool', self._subnet_pool.name),
         ]
-
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
         columns, data = self.cmd.take_action(parsed_args)
 
         self.network.find_subnet_pool.assert_called_with(
             self._subnet_pool.name,
             ignore_missing=False
         )
-
         self.assertEqual(self.columns, columns)
         self.assertEqual(self.data, data)