compute: Add missing options for 'server event list'

Add pagination parameters, '--limit' and '--offset', and filtering
parameters, '--changes-since' and '--changes-before'.

Change-Id: Ieca8267c3b204ae2db580502cc8fe72c95eddf09
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>

1 files changed, 234 insertions, 1 deletions

diff --git a/openstackclient/tests/unit/compute/v2/test_server_event.py b/openstackclient/tests/unit/compute/v2/test_server_event.py
index 5c94891a..058a44d8 100644
--- a/openstackclient/tests/unit/compute/v2/test_server_event.py
+++ b/openstackclient/tests/unit/compute/v2/test_server_event.py
@@ -11,7 +11,12 @@
 #   WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 #   License for the specific language governing permissions and limitations
 #   under the License.
-#
+
+from unittest import mock
+
+import iso8601
+from novaclient import api_versions
+from osc_lib import exceptions
 
 from openstackclient.compute.v2 import server_event
 from openstackclient.tests.unit.compute.v2 import fakes as compute_fakes
@@ -113,6 +118,234 @@ class TestListServerEvent(TestServerEvent):
         self.assertEqual(self.long_columns, columns)
         self.assertEqual(self.long_data, tuple(data))
 
+    def test_server_event_list_with_changes_since(self):
+        self.app.client_manager.compute.api_version = \
+            api_versions.APIVersion('2.58')
+
+        arglist = [
+            '--changes-since', '2016-03-04T06:27:59Z',
+            self.fake_server.name,
+        ]
+        verifylist = [
+            ('server', self.fake_server.name),
+            ('changes_since', '2016-03-04T06:27:59Z'),
+        ]
+
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        columns, data = self.cmd.take_action(parsed_args)
+
+        self.servers_mock.get.assert_called_once_with(self.fake_server.name)
+        self.events_mock.list.assert_called_once_with(
+            self.fake_server.id, changes_since='2016-03-04T06:27:59Z')
+
+        self.assertEqual(self.columns, columns)
+        self.assertEqual(tuple(self.data), tuple(data))
+
+    @mock.patch.object(iso8601, 'parse_date', side_effect=iso8601.ParseError)
+    def test_server_event_list_with_changes_since_invalid(
+        self, mock_parse_isotime,
+    ):
+        self.app.client_manager.compute.api_version = \
+            api_versions.APIVersion('2.58')
+
+        arglist = [
+            '--changes-since', 'Invalid time value',
+            self.fake_server.name,
+        ]
+        verifylist = [
+            ('server', self.fake_server.name),
+            ('changes_since', 'Invalid time value'),
+        ]
+
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        ex = self.assertRaises(
+            exceptions.CommandError,
+            self.cmd.take_action,
+            parsed_args)
+
+        self.assertIn(
+            'Invalid changes-since value:', str(ex))
+        mock_parse_isotime.assert_called_once_with(
+            'Invalid time value'
+        )
+
+    def test_server_event_list_with_changes_since_pre_v258(self):
+        self.app.client_manager.compute.api_version = \
+            api_versions.APIVersion('2.57')
+
+        arglist = [
+            '--changes-since', '2016-03-04T06:27:59Z',
+            self.fake_server.name,
+        ]
+        verifylist = [
+            ('server', self.fake_server.name),
+            ('changes_since', '2016-03-04T06:27:59Z'),
+        ]
+
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        ex = self.assertRaises(
+            exceptions.CommandError,
+            self.cmd.take_action,
+            parsed_args)
+
+        self.assertIn(
+            '--os-compute-api-version 2.58 or greater is required', str(ex))
+
+    def test_server_event_list_with_changes_before(self):
+        self.app.client_manager.compute.api_version = \
+            api_versions.APIVersion('2.66')
+
+        arglist = [
+            '--changes-before', '2016-03-04T06:27:59Z',
+            self.fake_server.name,
+        ]
+        verifylist = [
+            ('server', self.fake_server.name),
+            ('changes_before', '2016-03-04T06:27:59Z'),
+        ]
+
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        columns, data = self.cmd.take_action(parsed_args)
+
+        self.servers_mock.get.assert_called_once_with(self.fake_server.name)
+        self.events_mock.list.assert_called_once_with(
+            self.fake_server.id, changes_before='2016-03-04T06:27:59Z')
+
+        self.assertEqual(self.columns, columns)
+        self.assertEqual(tuple(self.data), tuple(data))
+
+    @mock.patch.object(iso8601, 'parse_date', side_effect=iso8601.ParseError)
+    def test_server_event_list_with_changes_before_invalid(
+        self, mock_parse_isotime,
+    ):
+        self.app.client_manager.compute.api_version = \
+            api_versions.APIVersion('2.66')
+
+        arglist = [
+            '--changes-before', 'Invalid time value',
+            self.fake_server.name,
+        ]
+        verifylist = [
+            ('server', self.fake_server.name),
+            ('changes_before', 'Invalid time value'),
+        ]
+
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        ex = self.assertRaises(
+            exceptions.CommandError,
+            self.cmd.take_action,
+            parsed_args)
+
+        self.assertIn(
+            'Invalid changes-before value:', str(ex))
+        mock_parse_isotime.assert_called_once_with(
+            'Invalid time value'
+        )
+
+    def test_server_event_list_with_changes_before_pre_v266(self):
+        self.app.client_manager.compute.api_version = \
+            api_versions.APIVersion('2.65')
+
+        arglist = [
+            '--changes-before', '2016-03-04T06:27:59Z',
+            self.fake_server.name,
+        ]
+        verifylist = [
+            ('server', self.fake_server.name),
+            ('changes_before', '2016-03-04T06:27:59Z'),
+        ]
+
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        ex = self.assertRaises(
+            exceptions.CommandError,
+            self.cmd.take_action,
+            parsed_args)
+
+        self.assertIn(
+            '--os-compute-api-version 2.66 or greater is required', str(ex))
+
+    def test_server_event_list_with_limit(self):
+        self.app.client_manager.compute.api_version = \
+            api_versions.APIVersion('2.58')
+
+        arglist = [
+            '--limit', '1',
+            self.fake_server.name,
+        ]
+        verifylist = [
+            ('limit', 1),
+            ('server', self.fake_server.name),
+        ]
+
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        self.cmd.take_action(parsed_args)
+
+        self.events_mock.list.assert_called_once_with(
+            self.fake_server.id, limit=1)
+
+    def test_server_event_list_with_limit_pre_v258(self):
+        self.app.client_manager.compute.api_version = \
+            api_versions.APIVersion('2.57')
+
+        arglist = [
+            '--limit', '1',
+            self.fake_server.name,
+        ]
+        verifylist = [
+            ('limit', 1),
+            ('server', self.fake_server.name),
+        ]
+
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        ex = self.assertRaises(
+            exceptions.CommandError,
+            self.cmd.take_action,
+            parsed_args)
+
+        self.assertIn(
+            '--os-compute-api-version 2.58 or greater is required', str(ex))
+
+    def test_server_event_list_with_marker(self):
+        self.app.client_manager.compute.api_version = \
+            api_versions.APIVersion('2.58')
+
+        arglist = [
+            '--marker', 'test_event',
+            self.fake_server.name,
+        ]
+        verifylist = [
+            ('marker', 'test_event'),
+            ('server', self.fake_server.name),
+        ]
+
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        self.cmd.take_action(parsed_args)
+
+        self.events_mock.list.assert_called_once_with(
+            self.fake_server.id, marker='test_event')
+
+    def test_server_event_list_with_marker_pre_v258(self):
+        self.app.client_manager.compute.api_version = \
+            api_versions.APIVersion('2.57')
+
+        arglist = [
+            '--marker', 'test_event',
+            self.fake_server.name,
+        ]
+        verifylist = [
+            ('marker', 'test_event'),
+            ('server', self.fake_server.name),
+        ]
+
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        ex = self.assertRaises(
+            exceptions.CommandError,
+            self.cmd.take_action,
+            parsed_args)
+
+        self.assertIn(
+            '--os-compute-api-version 2.58 or greater is required', str(ex))
+
 
 class TestShowServerEvent(TestServerEvent):